[webkit-changes] [WebKit/WebKit] 80db98: Add size assert for Element

Rob Buis noreply at github.com
Thu Dec 22 05:21:53 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 80db98e4cb00b296185031cc4ccdb4e902982180
      https://github.com/WebKit/WebKit/commit/80db98e4cb00b296185031cc4ccdb4e902982180
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2022-12-22 (Thu, 22 Dec 2022)

  Changed paths:
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/dom/ElementRareData.h
    M Source/WebCore/dom/NodeRareData.h

  Log Message:
  -----------
  Add size assert for Element
https://bugs.webkit.org/show_bug.cgi?id=249295

Reviewed by Antti Koivisto.

To keep Element a reasonable size move two existing flags
to rare data and add a static_assert to verify that
Element does not grow in the future.

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::hasDuplicateAttribute const):
(WebCore::Element::setHasDuplicateAttribute):
(WebCore::Element::displayContentsChanged const):
(WebCore::Element::setDisplayContentsChanged):
* Source/WebCore/dom/Element.h:
(WebCore::Element::hasDuplicateAttribute const): Deleted.
(WebCore::Element::setHasDuplicateAttribute): Deleted.
(WebCore::Element::displayContentsChanged const): Deleted.
(WebCore::Element::setDisplayContentsChanged): Deleted.
* Source/WebCore/dom/ElementRareData.h:
(WebCore::ElementRareData::hasDuplicateAttribute const):
(WebCore::ElementRareData::setHasDuplicateAttribute):
(WebCore::ElementRareData::displayContentsChanged const):
(WebCore::ElementRareData::setDisplayContentsChanged):
* Source/WebCore/dom/NodeRareData.h:

Canonical link: https://commits.webkit.org/258238@main




More information about the webkit-changes mailing list