[webkit-changes] [WebKit/WebKit] 0a821c: Make sure rows are updated during simplified layout

Ahmad Saleem noreply at github.com
Wed Dec 21 18:22:09 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a821c7d68ea240665ed1a0aaceefe1bddbebb5f
      https://github.com/WebKit/WebKit/commit/0a821c7d68ea240665ed1a0aaceefe1bddbebb5f
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-12-21 (Wed, 21 Dec 2022)

  Changed paths:
    A LayoutTests/fast/table/table-overflow-crash-expected.txt
    A LayoutTests/fast/table/table-overflow-crash.html
    M Source/WebCore/rendering/RenderTable.cpp

  Log Message:
  -----------
  Make sure rows are updated during simplified layout

Make sure rows are updated during simplified layout
https://bugs.webkit.org/show_bug.cgi?id=249707

Reviewed by Alan Baradlay.

Merge - https://src.chromium.org/viewvc/blink?revision=191146&view=revision

When we are calling RenderTable::simplifiedNormalFlowLayout(), we have to
make sure that we call section->layoutRows() before we do the
section->computeOverflowFromCells(). The call to layoutRows is needed because
it will reset and update the m_forceSlowPaintPathWithOverflowingCell
flag which causes to fail the ASSERT.

* Source/WebCore/rendering/RenderTable.cpp:
(RenderTable::simplifiedNormalFlowLayout): Add "layoutRows" before "computeOverflowFromCells"
* LayoutTests/fast/table/table-overflow-crash.html: Add Test Case
* LayoutTests/fast/table/table-overflow-crash-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/258227@main




More information about the webkit-changes mailing list