[webkit-changes] [WebKit/WebKit] 6b38cc: FrameView::frame should return an AbstractFrame

Alex Christensen noreply at github.com
Wed Dec 21 13:07:28 PST 2022 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b38cc78aea225f0b479c89d29fe027e958635d0
      https://github.com/WebKit/WebKit/commit/6b38cc78aea225f0b479c89d29fe027e958635d0
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2022-12-21 (Wed, 21 Dec 2022)

  Changed paths:
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/AccessibilityScrollView.cpp
    M Source/WebCore/display/DisplayView.cpp
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/editing/FrameSelection.cpp
    M Source/WebCore/history/CachedFrame.cpp
    M Source/WebCore/history/CachedPage.cpp
    M Source/WebCore/inspector/InspectorInstrumentation.cpp
    M Source/WebCore/inspector/InspectorInstrumentation.h
    M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
    M Source/WebCore/inspector/agents/InspectorPageAgent.cpp
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebCore/page/Frame.cpp
    M Source/WebCore/page/FrameView.cpp
    M Source/WebCore/page/FrameView.h
    M Source/WebCore/page/FrameViewLayoutContext.cpp
    M Source/WebCore/page/ModalContainerObserver.cpp
    M Source/WebCore/page/PageColorSampler.cpp
    M Source/WebCore/page/mac/EventHandlerMac.mm
    M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
    M Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderIFrame.cpp
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayerCompositor.cpp
    M Source/WebCore/rendering/RenderTreeAsText.cpp
    M Source/WebCore/rendering/RenderView.cpp
    M Source/WebCore/rendering/RenderWidget.cpp
    M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
    M Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
    M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp
    M Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm
    M Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKitLegacy/win/WebView.cpp

  Log Message:
  -----------
  FrameView::frame should return an AbstractFrame
https://bugs.webkit.org/show_bug.cgi?id=249662
rdar://103564957

Reviewed by Chris Dumez.

This is in preparation for a RemoteFrame to have a view object that is different
from FrameView but inherits from a shared parent class, like Frame/RemoteFrame/AbstractFrame
do now.

* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::appendAccessibilityObject):
(WebCore::AccessibilityObject::document const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint const):
(WebCore::AccessibilityRenderObject::remoteSVGRootElement const):
* Source/WebCore/accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::document const):
* Source/WebCore/display/DisplayView.cpp:
(WebCore::Display::View::frame const):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::resolveStyle):
(WebCore::Document::attachToCachedFrame):
(WebCore::computeIntersectionState):
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::CaretBase::shouldRepaintCaret const):
* Source/WebCore/history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::open):
(WebCore::CachedFrame::destroy):
* Source/WebCore/history/CachedPage.cpp:
(WebCore::CachedPage::restore):
* Source/WebCore/inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didAddOrRemoveScrollbarsImpl):
* Source/WebCore/inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didAddOrRemoveScrollbars):
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):
* Source/WebCore/inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didPaint):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::subframeForTargetNode):
* Source/WebCore/page/Frame.cpp:
(WebCore::Frame::frameForWidget):
(WebCore::Frame::clearTimers):
* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::removeFromAXObjectCache):
(WebCore::FrameView::init):
(WebCore::FrameView::recalculateScrollbarOverlayStyle):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::rootElementForCustomScrollbarPartStyle const):
(WebCore::FrameView::createScrollbar):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::applyPaginationToViewport):
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::updateSnapOffsets):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::setNeedsOneShotDrawingSynchronization):
(WebCore::FrameView::graphicsLayerForPageScale):
(WebCore::FrameView::graphicsLayerForTransientZoomShadow):
(WebCore::FrameView::fixedScrollableAreaBoundsInflatedForScrolling const):
(WebCore::FrameView::scrollPositionRespectingCustomFixedPosition const):
(WebCore::FrameView::headerHeight const):
(WebCore::FrameView::footerHeight const):
(WebCore::FrameView::topContentInset const):
(WebCore::FrameView::isEnclosedInCompositingLayer const):
(WebCore::FrameView::flushCompositingStateIncludingSubframes):
(WebCore::FrameView::forceLayoutParentViewIfNeeded):
(WebCore::FrameView::markRootOrBodyRendererDirty const):
(WebCore::FrameView::adjustScrollbarsForLayout):
(WebCore::FrameView::willDoLayout):
(WebCore::FrameView::didLayout):
(WebCore::FrameView::mediaType const):
(WebCore::FrameView::mockScrollbarsControllerEnabled const):
(WebCore::FrameView::logMockScrollbarsControllerMessage const):
(WebCore::FrameView::debugDescription const):
(WebCore::FrameView::setBaseLayoutViewportOrigin):
(WebCore::FrameView::setLayoutViewportOverrideRect):
(WebCore::FrameView::updateLayoutViewport):
(WebCore::FrameView::viewportConstrainedVisibleContentRect const):
(WebCore::FrameView::rectForFixedPositionLayout const):
(WebCore::FrameView::frameScaleFactor const):
(WebCore::FrameView::scrollPositionForFixedPosition const):
(WebCore::FrameView::viewportConstrainedObjectsRect const):
(WebCore::FrameView::minimumScrollPosition const):
(WebCore::FrameView::maximumScrollPosition const):
(WebCore::FrameView::unscaledMinimumScrollPosition const):
(WebCore::FrameView::unscaledMaximumScrollPosition const):
(WebCore::FrameView::viewportContentsChanged):
(WebCore::FrameView::viewRectExpandedByContentInsets const):
(WebCore::FrameView::fixedElementsLayoutRelativeToFrame const):
(WebCore::FrameView::lastKnownMousePositionInView const):
(WebCore::FrameView::isHandlingWheelEvent const):
(WebCore::FrameView::shouldSetCursor const):
(WebCore::FrameView::rendererForColorScheme const):
(WebCore::FrameView::useDarkAppearance const):
(WebCore::FrameView::styleColorOptions const):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::scrollToFragment):
(WebCore::FrameView::scrollToFragmentInternal):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::scrollElementToRect):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::resetScrollAnchor):
(WebCore::FrameView::scrollToFocusedElementInternal):
(WebCore::FrameView::textFragmentIndicatorTimerFired):
(WebCore::FrameView::scrollRectToVisible):
(WebCore::scrollPositionChangeOptionsForElement):
(WebCore::FrameView::scrollRectToVisibleInChildView):
(WebCore::FrameView::scrollRectToVisibleInTopLevelView):
(WebCore::FrameView::setFixedVisibleContentRect):
(WebCore::FrameView::didChangeScrollOffset):
(WebCore::FrameView::scrollOffsetChangedViaPlatformWidgetImpl):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::applyRecursivelyWithVisibleRect):
(WebCore::FrameView::resumeVisibleImageAnimations):
(WebCore::FrameView::updatePlayStateForAllAnimations):
(WebCore::FrameView::updateScriptedAnimationsAndTimersThrottlingState):
(WebCore::FrameView::scrollingCoordinator const):
(WebCore::FrameView::shouldUpdateCompositingLayersAfterScrolling const):
(WebCore::FrameView::hostWindow const):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::renderedCharactersExceed):
(WebCore::FrameView::availableContentSizeChanged):
(WebCore::FrameView::updateContentsSize):
(WebCore::FrameView::computeScrollability const):
(WebCore::FrameView::layoutOrVisualViewportChanged):
(WebCore::FrameView::loadProgressingStatusChanged):
(WebCore::shouldEnableSpeculativeTilingDuringLoading):
(WebCore::FrameView::show):
(WebCore::FrameView::calculateExtendedBackgroundMode const):
(WebCore::FrameView::safeToPropagateScrollToParent const):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::scrollToTextFragmentRange):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::scheduleResizeEventIfNeeded):
(WebCore::FrameView::autoSizeIfEnabled):
(WebCore::FrameView::performFixedWidthAutoSize):
(WebCore::FrameView::performSizeToContentAutoSize):
(WebCore::FrameView::viewportRenderer const):
(WebCore::FrameView::updateOverflowStatus):
(WebCore::FrameView::pagination const):
(WebCore::FrameView::setPagination):
(WebCore::FrameView::windowClipRect const):
(WebCore::FrameView::isActive const):
(WebCore::FrameView::forceUpdateScrollbarsOnMainThreadForPerformanceTesting const):
(WebCore::FrameView::adjustVerticalPageScrollStepForFixedContent):
(WebCore::FrameView::visibleContentScaleFactor const):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::enclosingScrollableArea const):
(WebCore::FrameView::scrollableAreaBoundingBox const):
(WebCore::FrameView::isScrollable):
(WebCore::FrameView::hasScrollableOrRubberbandableAncestor):
(WebCore::FrameView::shouldSuspendScrollAnimations const):
(WebCore::FrameView::scrollbarStyleChanged):
(WebCore::FrameView::notifyAllFramesThatContentAreaWillPaint const):
(WebCore::FrameView::notifyScrollableAreasThatContentAreaWillPaint const):
(WebCore::FrameView::scrollAnimatorEnabled const):
(WebCore::FrameView::updateScrollCorner):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintScrollbar):
(WebCore::FrameView::documentBackgroundColor const):
(WebCore::FrameView::parentFrameView const):
(WebCore::FrameView::updateControlTints):
(WebCore::FrameView::willPaintContents):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::paintOverhangAreas):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
(WebCore::FrameView::updateHasReachedSignificantRenderedTextThreshold):
(WebCore::FrameView::qualifiesAsSignificantRenderedText const):
(WebCore::FrameView::checkAndDispatchDidReachVisuallyNonEmptyState):
(WebCore::FrameView::enableSizeToContentAutoSizeMode):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::convertToContainingView const):
(WebCore::FrameView::convertFromContainingView const):
(WebCore::FrameView::documentToAbsoluteScaleFactor const):
(WebCore::FrameView::documentToClientOffset const):
(WebCore::FrameView::absoluteToLayoutViewportPoint const):
(WebCore::FrameView::layoutViewportToAbsolutePoint const):
(WebCore::FrameView::layoutViewportToAbsoluteRect const):
(WebCore::FrameView::absoluteToLayoutViewportRect const):
(WebCore::FrameView::clientToLayoutViewportRect const):
(WebCore::FrameView::clientToLayoutViewportPoint const):
(WebCore::FrameView::setTracksRepaints):
(WebCore::FrameView::trackedRepaintRectsAsText const):
(WebCore::FrameView::scheduleScrollEvent):
(WebCore::FrameView::axObjectCache const):
(WebCore::FrameView::useCustomFixedPositionLayoutRect const):
(WebCore::FrameView::updateFixedPositionLayoutRect):
(WebCore::FrameView::setScrollingPerformanceTestingEnabled):
(WebCore::FrameView::didAddScrollbar):
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
(WebCore::FrameView::firePaintRelatedMilestonesIfNeeded):
(WebCore::FrameView::setVisualUpdatesAllowedByClient):
(WebCore::FrameView::scrollBehaviorForFixedElements const):
(WebCore::FrameView::renderView const):
(WebCore::FrameView::mapFromLayoutToCSSUnits const):
(WebCore::FrameView::mapFromCSSToLayoutUnits const):
(WebCore::FrameView::setViewExposedRect):
(WebCore::FrameView::clearSizeOverrideForCSSDefaultViewportUnits):
(WebCore::FrameView::setOverrideSizeForCSSDefaultViewportUnits):
(WebCore::FrameView::clearSizeOverrideForCSSSmallViewportUnits):
(WebCore::FrameView::setOverrideSizeForCSSSmallViewportUnits):
(WebCore::FrameView::clearSizeOverrideForCSSLargeViewportUnits):
(WebCore::FrameView::setOverrideSizeForCSSLargeViewportUnits):
(WebCore::FrameView::sizeForCSSDynamicViewportUnits const):
(WebCore::FrameView::didFinishProhibitingScrollingWhenChangingContentSize):
(WebCore::FrameView::pageScaleFactor const):
(WebCore::FrameView::didStartScrollAnimation):
(WebCore::FrameView::updateScrollbarSteps):
(WebCore::FrameView::horizontalOverscrollBehavior const):
(WebCore::FrameView::verticalOverscrollBehavior const):
(WebCore::FrameView::isVisibleToHitTesting const):
(WebCore::FrameView::getPossiblyFixedRectToExpose const):
* Source/WebCore/page/FrameView.h:
* Source/WebCore/page/FrameViewLayoutContext.cpp:
(WebCore::FrameViewLayoutContext::performLayout):
(WebCore::FrameViewLayoutContext::frame const):
* Source/WebCore/page/ModalContainerObserver.cpp:
(WebCore::ModalContainerObserver::updateModalContainerIfNeeded):
(WebCore::ModalContainerObserver::hideUserInteractionBlockingElementIfNeeded):
* Source/WebCore/page/PageColorSampler.cpp:
(WebCore::sampleColor):
* Source/WebCore/page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWheelEventToWidget):
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged):
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):
(WebCore::AsyncScrollingCoordinator::setFrameScrollingNodeState):
* Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView const):
(WebCore::ScrollingCoordinator::scrollContainerLayerForFrameView):
(WebCore::ScrollingCoordinator::scrolledContentsLayerForFrameView):
(WebCore::ScrollingCoordinator::headerLayerForFrameView):
(WebCore::ScrollingCoordinator::footerLayerForFrameView):
(WebCore::ScrollingCoordinator::counterScrollingLayerForFrameView):
(WebCore::ScrollingCoordinator::insetClipLayerForFrameView):
(WebCore::ScrollingCoordinator::contentShadowLayerForFrameView):
(WebCore::ScrollingCoordinator::rootContentsLayerForFrameView):
(WebCore::ScrollingCoordinator::updateSynchronousScrollingReasons):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::adjustComputedFontSizesOnBlocks):
(WebCore::RenderElement::resetTextAutosizing):
* Source/WebCore/rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::contentRootRenderer const):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::isMainFrameCompositor const):
(WebCore::RenderLayerCompositor::ensureRootLayer):
(WebCore::RenderLayerCompositor::attachRootLayer):
(WebCore::RenderLayerCompositor::detachRootLayer):
(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged):
* Source/WebCore/rendering/RenderTreeAsText.cpp:
(WebCore::write):
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::clientLogicalWidthForFixedPosition const):
(WebCore::RenderView::clientLogicalHeightForFixedPosition const):
(WebCore::RenderView::shouldUsePrintingLayout const):
(WebCore::RenderView::zoomFactor const):
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetPosition):
(WebCore::RenderWidget::nodeAtPoint):
* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::convertRectFromFrameClientToRootView):
(WebKit::convertPointFromFrameClientToRootView):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::shouldUseTiledBackingForFrameView const):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::updateVisibleContentRects):
* Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrameView const):

Canonical link: https://commits.webkit.org/258209@main

More information about the webkit-changes mailing list