[webkit-changes] [WebKit/WebKit] fc5283: [WK2] Daemon::Decoder::decodeFixedLengthReference(...

[Žan Doberšek]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc52838b1ca2a502b206c398f5f08df1d6803e9e
      https://github.com/WebKit/WebKit/commit/fc52838b1ca2a502b206c398f5f08df1d6803e9e
  Author: Žan Doberšek <zdobersek at igalia.com>
  Date:   2022-12-21 (Wed, 21 Dec 2022)

  Changed paths:
    M Source/WebKit/Platform/IPC/DaemonCoders.cpp
    M Source/WebKit/Platform/IPC/DaemonDecoder.cpp
    M Source/WebKit/Platform/IPC/DaemonDecoder.h

  Log Message:
  -----------
  [WK2] Daemon::Decoder::decodeFixedLengthReference() should return a Span
https://bugs.webkit.org/show_bug.cgi?id=249704

Reviewed by Kimmo Kinnunen.

Instead of a raw pointer, Daemon::Decoder::decodeFixedLengthReference()
should return a Span<const uint8> object describing the memory area
retrieved from the decoder.

The sole use in CertificateInfo decoding is adjusted. To test the Span's
validity, the Span's size is compared to the requested size, which will
be the same when retrieval from the decoder succeeds.

* Source/WebKit/Platform/IPC/DaemonCoders.cpp:
(WebKit::Daemon::Coder<WebCore::CertificateInfo>::decode):
* Source/WebKit/Platform/IPC/DaemonDecoder.cpp:
(WebKit::Daemon::Decoder::decodeFixedLengthReference):
* Source/WebKit/Platform/IPC/DaemonDecoder.h:

Canonical link: https://commits.webkit.org/258193@main