[webkit-changes] [WebKit/WebKit] 409456: BitStack::top() should calculate an index instead ...

Ahmad Saleem noreply at github.com
Wed Dec 21 07:07:11 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 409456bc5cee21871671023b1e50b426604e0ce7
      https://github.com/WebKit/WebKit/commit/409456bc5cee21871671023b1e50b426604e0ce7
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-12-21 (Wed, 21 Dec 2022)

  Changed paths:
    M Source/WebCore/editing/TextIterator.cpp

  Log Message:
  -----------
  BitStack::top() should calculate an index instead of always using m_words.last()

BitStack::top() should calculate an index instead of always using m_words.last()
https://bugs.webkit.org/show_bug.cgi?id=142224

Reviewed by Antti Koivisto.

Merge - https://chromium.googlesource.com/chromium/blink/+/6513eab4e0dae0ff8556dd6ddbbb9c475bec2d32

This patch is to fix a logical error, where if the stack gets deeper than sizeof(unsigned),
the result reported by top() can be incorrect if anything has been popped.

* Source/WebCore/editing/TextIterator.cpp:
(BitStack::top): Add unsigned variable "index" and use it as an array for return value

Canonical link: https://commits.webkit.org/258190@main




More information about the webkit-changes mailing list