[webkit-changes] [WebKit/WebKit] 8d41f7: [IFC][hanging punctuation] InlineContentBreaker sh...
Alan Baradlay
noreply at github.com
Tue Dec 20 22:32:38 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8d41f722d967fb2d3fd042265f76ba2bff51b6bf
https://github.com/WebKit/WebKit/commit/8d41f722d967fb2d3fd042265f76ba2bff51b6bf
Author: Alan Baradlay <zalan at apple.com>
Date: 2022-12-20 (Tue, 20 Dec 2022)
Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
Log Message:
-----------
[IFC][hanging punctuation] InlineContentBreaker should not care if hanging content is leading or trailing
https://bugs.webkit.org/show_bug.cgi?id=249652
Reviewed by Antti Koivisto.
Hanging content is not supposed to take up space in the line box. It simply means that InlineContentBreaker
should ignore it when checking for fit computation. From InlineContentBreaker's point of view
it does not matter whether the hanging content is at the beginning or at the end of the continuous candidate content.
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::ContinuousContent::reset):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::appendTrailingHangingContent): Deleted.
(WebCore::Layout::InlineContentBreaker::ContinuousContent::appendLeadingHangingContent): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h:
(WebCore::Layout::InlineContentBreaker::ContinuousContent::hangingContentWidth const):
(WebCore::Layout::InlineContentBreaker::ContinuousContent::setHangingContentWidth):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineCandidate::InlineContent::appendInlineItem):
Canonical link: https://commits.webkit.org/258181@main
More information about the webkit-changes
mailing list