[webkit-changes] [WebKit/WebKit] dcd38b: [CMake] Simplify Tools build

Don Olmstead noreply at github.com
Tue Dec 20 21:27:32 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dcd38bfaf2a851a2994f65f74148a501c538bff4
      https://github.com/WebKit/WebKit/commit/dcd38bfaf2a851a2994f65f74148a501c538bff4
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2022-12-20 (Tue, 20 Dec 2022)

  Changed paths:
    M Source/cmake/OptionsPlayStation.cmake
    M Source/cmake/OptionsWin.cmake
    M Source/cmake/WebKitFeatures.cmake
    M Tools/CMakeLists.txt
    M Tools/PlatformGTK.cmake
    M Tools/PlatformPlayStation.cmake
    M Tools/PlatformWPE.cmake
    M Tools/PlatformWin.cmake

  Log Message:
  -----------
  [CMake] Simplify Tools build
https://bugs.webkit.org/show_bug.cgi?id=249669

Reviewed by Michael Catanzaro and Carlos Alberto Lopez Perez.

Centralize the additions targets for `ImageDiff`, `TestRunnerShared`,
`DumpRenderTree` and `WebKitTestRunner`.

Add an `ENABLE_IMAGE_DIFF` option for building `ImageDiff` for layout
tests. By default this is `ON` but it is turned `OFF` for PlayStation
since it can't run on device during testing.

Set `ENABLE_MINIBROWSER` and `ENABLE_LAYOUT_TESTS` for the Windows
builds. Use `ENABLE_MINIBROWSER` for adding the `MiniBrowser` target.

* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Tools/CMakeLists.txt:
* Tools/PlatformGTK.cmake:
* Tools/PlatformPlayStation.cmake:
* Tools/PlatformWPE.cmake:
* Tools/PlatformWin.cmake:

Canonical link: https://commits.webkit.org/258179@main




More information about the webkit-changes mailing list