[webkit-changes] [WebKit/WebKit] a5f12d: [GPU Process] [FormControls] Add a ControlPart for...
Said Abou-Hallawa
noreply at github.com
Tue Dec 20 19:37:58 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a5f12d1b9232202fd842ed8b615d2baed86aa271
https://github.com/WebKit/WebKit/commit/a5f12d1b9232202fd842ed8b615d2baed86aa271
Author: Said Abou-Hallawa <said at apple.com>
Date: 2022-12-20 (Tue, 20 Dec 2022)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/graphics/controls/ControlFactory.h
A Source/WebCore/platform/graphics/controls/ToggleButtonPart.h
A Source/WebCore/platform/graphics/mac/controls/ButtonControlMac.h
A Source/WebCore/platform/graphics/mac/controls/ButtonControlMac.mm
M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h
M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm
M Source/WebCore/platform/graphics/mac/controls/ControlMac.h
M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm
A Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.h
A Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.mm
M Source/WebCore/platform/mac/ThemeMac.mm
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderThemeMac.mm
M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
Log Message:
-----------
[GPU Process] [FormControls] Add a ControlPart for ToggleButton
https://bugs.webkit.org/show_bug.cgi?id=249638
rdar://103548470
Reviewed by Aditya Keerthi.
It will handle drawing the checkbox and the radio buttons. ButtonControlMac will
be introduced as the base class of ToggleButtonMac. It will also be the base class
of the ButtonMac which will be submitted in a future patch.
* Source/WebCore/Headers.cmake:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/controls/ControlFactory.h:
* Source/WebCore/platform/graphics/controls/ToggleButtonPart.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h.
* Source/WebCore/platform/graphics/mac/controls/ButtonControlMac.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h.
* Source/WebCore/platform/graphics/mac/controls/ButtonControlMac.mm: Added.
(WebCore::ButtonControlMac::ButtonControlMac):
(WebCore::ButtonControlMac::updateCellStates):
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm:
(WebCore::createToggleButtonCell):
(WebCore::ControlFactoryMac::checkboxCell const):
(WebCore::ControlFactoryMac::radioCell const):
(WebCore::ControlFactoryMac::createPlatformToggleButton):
* Source/WebCore/platform/graphics/mac/controls/ControlMac.h:
(WebCore::ControlMac::cellSize const):
(WebCore::ControlMac::cellOutsets const):
* Source/WebCore/platform/graphics/mac/controls/ControlMac.mm:
(WebCore::ControlMac::calculateControlSize const):
* Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h.
* Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.mm: Added.
(WebCore::ToggleButtonMac::ToggleButtonMac):
(WebCore::ToggleButtonMac::cellSize const):
(WebCore::ToggleButtonMac::cellOutsets const):
(WebCore::ToggleButtonMac::draw):
* Source/WebCore/platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::paint):
(WebCore::paintToggleButton): Deleted.
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::createControlPart const):
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::canPaint const):
(WebCore::RenderThemeMac::canCreateControlPartForRenderer const):
(WebCore::RenderThemeMac::canCreateControlPartForBorderOnly const):
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ControlPart>::decode):
Canonical link: https://commits.webkit.org/258177@main
More information about the webkit-changes
mailing list