[webkit-changes] [WebKit/WebKit] 129274: Call Document::willBeRemovedFromFrame before swapp...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1292748ffd5245756ff9e1ae5a5b6e974f5c5936
      https://github.com/WebKit/WebKit/commit/1292748ffd5245756ff9e1ae5a5b6e974f5c5936
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2022-12-20 (Tue, 20 Dec 2022)

  Changed paths:
    M Source/WebCore/dom/Document.h
    M Source/WebKit/WebProcess/WebPage/WebFrame.cpp

  Log Message:
  -----------
  Call Document::willBeRemovedFromFrame before swapping a Frame for a RemoteFrame
https://bugs.webkit.org/show_bug.cgi?id=249665
rdar://103565224

Reviewed by Simon Fraser.

This fixes crashes when using site isolation and loading cross-origin iframes
because the render tree is still attached to a Document which no longer has a
Frame before this change, but after this change the render tree is detached.
This makes investigation of bugs much easier and is the first step towards
hooking up drawing code for remote frames.

* Source/WebCore/dom/Document.h:
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::didCommitLoadInAnotherProcess):

Canonical link: https://commits.webkit.org/258161@main