[webkit-changes] [WebKit/WebKit] 9fa141: [GPU Process] [FormControls] Add a ControlPart for...

Said Abou-Hallawa noreply at github.com
Tue Dec 20 11:42:59 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9fa141672fb9121359edf625906088ce8aa40843
      https://github.com/WebKit/WebKit/commit/9fa141672fb9121359edf625906088ce8aa40843
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2022-12-20 (Tue, 20 Dec 2022)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/platform/graphics/controls/ControlFactory.h
    A Source/WebCore/platform/graphics/controls/TextAreaPart.h
    M Source/WebCore/platform/graphics/controls/TextFieldPart.h
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm
    A Source/WebCore/platform/graphics/mac/controls/TextAreaMac.h
    A Source/WebCore/platform/graphics/mac/controls/TextAreaMac.mm
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderThemeMac.h
    M Source/WebCore/rendering/RenderThemeMac.mm
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp

  Log Message:
  -----------
  [GPU Process] [FormControls] Add a ControlPart for TextArea
https://bugs.webkit.org/show_bug.cgi?id=249629
rdar://103541252

Reviewed by Aditya Keerthi.

This ControlPart will draw a border around the TextArea and ListBox form controls.

* Source/WebCore/Headers.cmake:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/controls/ControlFactory.h:
* Source/WebCore/platform/graphics/controls/TextAreaPart.h: Copied from Source/WebCore/platform/graphics/controls/TextFieldPart.h.
* Source/WebCore/platform/graphics/controls/TextFieldPart.h:
(WebCore::TextFieldPart::create): Deleted.
(WebCore::TextFieldPart::TextFieldPart): Deleted.
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm:
(WebCore::ControlFactoryMac::createPlatformTextArea):
* Source/WebCore/platform/graphics/mac/controls/TextAreaMac.h: Copied from Source/WebCore/platform/graphics/controls/TextFieldPart.h.
* Source/WebCore/platform/graphics/mac/controls/TextAreaMac.mm: Copied from Source/WebCore/platform/graphics/controls/TextFieldPart.h.
(WebCore::TextAreaMac::TextAreaMac):
(WebCore::TextAreaMac::draw):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::createControlPart const):
* Source/WebCore/rendering/RenderThemeMac.h:
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::canPaint const):
(WebCore::RenderThemeMac::canCreateControlPartForBorderOnly const):
(WebCore::RenderThemeMac::paintTextArea): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ControlPart>::decode):

Canonical link: https://commits.webkit.org/258150@main




More information about the webkit-changes mailing list