[webkit-changes] [WebKit/WebKit] 497b43: [IFC][hanging punctuation] Inline box start/end wi...

Alan Baradlay noreply at github.com
Tue Dec 20 10:21:52 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 497b4332ca4b46ce01bbd463640e9c883f338a12
      https://github.com/WebKit/WebKit/commit/497b4332ca4b46ce01bbd463640e9c883f338a12
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2022-12-20 (Tue, 20 Dec 2022)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
    M Source/WebCore/layout/layouttree/LayoutBoxGeometry.h

  Log Message:
  -----------
  [IFC][hanging punctuation] Inline box start/end with decoration should reset trailing hanging content
https://bugs.webkit.org/show_bug.cgi?id=249647

Reviewed by Antti Koivisto.

Such inline boxes make hanging punctuation not hanging anymore. This addresses cases
when the preferred width value for content with hanging punctuation is incorrectly computed short by trimming
(visually not) hanging punctuation.

* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::initialize):
(WebCore::Layout::Line::appendInlineBoxStart):
(WebCore::Layout::Line::appendInlineBoxEnd):
(WebCore::Layout::Line::lineHasVisuallyNonEmptyContent const):
* Source/WebCore/layout/layouttree/LayoutBoxGeometry.h:
(WebCore::Layout::BoxGeometry::verticalMarginBorderAndPadding const):
(WebCore::Layout::BoxGeometry::marginBorderAndPaddingStart const):
(WebCore::Layout::BoxGeometry::marginBorderAndPaddingEnd const):
(WebCore::Layout::BoxGeometry::horizontalMarginBorderAndPadding const):
(WebCore::Layout::BoxGeometry::hasMarginBorderOrPadding const):

Canonical link: https://commits.webkit.org/258144@main




More information about the webkit-changes mailing list