[webkit-changes] [WebKit/WebKit] f34b82: CSSRule.type should not return values greater than 15

Antti Koivisto noreply at github.com
Tue Dec 20 00:18:35 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f34b82d5e7cb29e73606d63e4b1b39539c4b90b1
      https://github.com/WebKit/WebKit/commit/f34b82d5e7cb29e73606d63e4b1b39539c4b90b1
  Author: Antti Koivisto <antti at apple.com>
  Date:   2022-12-20 (Tue, 20 Dec 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-cssom-expected.txt
    M Source/WebCore/css/CSSRule.cpp
    M Source/WebCore/css/CSSRule.h
    M Source/WebCore/css/CSSRule.idl
    M Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp
    M Source/WebCore/css/StyleRuleType.h
    M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCSSRule.cpp
    M Source/WebKitLegacy/mac/DOM/DOMCSSRule.mm

  Log Message:
  -----------
  CSSRule.type should not return values greater than 15
https://bugs.webkit.org/show_bug.cgi?id=249560
rdar://103531316

Reviewed by Sam Weinig.

"This enumeration is thus frozen in its current state, and no new new values will be added to
reflect additional at-rules; all at-rules beyond the ones listed above will return 0."

https://w3c.github.io/csswg-drafts/cssom/#the-cssrule-interface

* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-cssom-expected.txt:
* Source/WebCore/css/CSSRule.cpp:
(WebCore::CSSRule::typeForCSSOM const):

Return 0 for unexposed types.
Rename for clarity.

* Source/WebCore/css/CSSRule.h:
(WebCore::CSSRule::type const): Deleted.
* Source/WebCore/css/CSSRule.idl:
* Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::StyleRuleCSSStyleDeclaration):
* Source/WebCore/css/StyleRuleType.h:
* Source/WebKitLegacy/mac/DOM/DOMCSSRule.mm:
(-[DOMCSSRule type]):

Canonical link: https://commits.webkit.org/258128@main




More information about the webkit-changes mailing list