[webkit-changes] [WebKit/WebKit] 56aa37: Fix issue where WebAuth timeouts lead to an incorr...
Charlie Wolfe
noreply at github.com
Mon Dec 19 18:31:29 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 56aa37f2fb910067390d664215376202a81cf464
https://github.com/WebKit/WebKit/commit/56aa37f2fb910067390d664215376202a81cf464
Author: Charlie Wolfe <charliew at apple.com>
Date: 2022-12-19 (Mon, 19 Dec 2022)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
Log Message:
-----------
Fix issue where WebAuth timeouts lead to an incorrect error
https://bugs.webkit.org/show_bug.cgi?id=249612
rdar://100825830
Reviewed by J Pascoe.
This corrects an issue where we unconditionally return a
WKErrorUnknown. This later leads to other issues when we
cast this error back to a WebCore::ExceptionCode, resulting
in an unrelated error being thrown.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(-[_WKWebAuthenticationPanel getAssertionWithChallenge:origin:options:completionHandler:]):
(-[_WKWebAuthenticationPanel getAssertionWithMediationRequirement:clientDataHash:options:completionHandler:]):
Canonical link: https://commits.webkit.org/258116@main
More information about the webkit-changes
mailing list