[webkit-changes] [WebKit/WebKit] b5a473: run-benchmark should not limit profile collection ...

hysu noreply at github.com
Mon Dec 19 17:00:16 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b5a473c9f6d72a1612f96e8ec51d8f24338232a6
      https://github.com/WebKit/WebKit/commit/b5a473c9f6d72a1612f96e8ec51d8f24338232a6
  Author: Hysu Xiong <hysu at apple.com>
  Date:   2022-12-19 (Mon, 19 Dec 2022)

  Changed paths:
    M Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py
    M Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py

  Log Message:
  -----------
  run-benchmark should not limit profile collection to macOS platforms
https://bugs.webkit.org/show_bug.cgi?id=249338
rdar://103372861

Reviewed by Stephanie Lewis.

- Remove restriction for being able to collect profiles on macOS
- Split file arg in `profile` context manager into directory and filename to avoid making assumptions about platforms, as some may collect profiles in different ways.

* Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(parse_args):
* Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
(WebServerBenchmarkRunner):

Canonical link: https://commits.webkit.org/258109@main




More information about the webkit-changes mailing list