[webkit-changes] [WebKit/WebKit] ba43a1: Unreviewed, revert 258061 at main because of 12% Spee...

Yusuke Suzuki noreply at github.com
Mon Dec 19 12:03:32 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ba43a12de521c79b313b957d635d422ce46e9b0c
      https://github.com/WebKit/WebKit/commit/ba43a12de521c79b313b957d635d422ce46e9b0c
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-12-19 (Mon, 19 Dec 2022)

  Changed paths:
    M LayoutTests/editing/pasteboard/copy-paste-inserts-clearing-div-expected.txt
    M LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt
    M LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt
    M LayoutTests/fast/css/background-clip-text-expected.txt
    M LayoutTests/fast/css/background-position-serialize-expected.txt
    M LayoutTests/fast/css/border-shorthand-initialize-longhands-expected.txt
    M LayoutTests/fast/css/longhand-overrides-shorthand-prefixing-expected.txt
    M LayoutTests/fast/css/parsing-text-emphasis-expected.txt
    M LayoutTests/fast/css/remove-shorthand-expected.txt
    M LayoutTests/fast/css/shorthand-mismatched-list-crash-expected.txt
    M LayoutTests/fast/css/transform-inline-style-expected.txt
    M LayoutTests/fast/css/transform-inline-style-remove-expected.txt
    M LayoutTests/fast/dom/background-shorthand-csstext-expected.txt
    M LayoutTests/fast/masking/parsing-mask-expected.txt
    M LayoutTests/fast/masking/parsing-webkit-mask-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/content-security-policy/style-src/inline-style-allowed-while-cloning-objects.sub-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-shorthand-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-position-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-valid.sub-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/column-rule-shorthand-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cssText-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/border-shorthand-serialization-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-values-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/shorthand-values-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-valid.sub-expected.txt
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/StyleProperties.cpp
    M Source/WebCore/css/StyleProperties.h
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.h

  Log Message:
  -----------
  Unreviewed, revert 258061 at main because of 12% Speedometer2 regression
https://bugs.webkit.org/show_bug.cgi?id=249599

* LayoutTests/editing/pasteboard/copy-paste-inserts-clearing-div-expected.txt:
* LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt:
* LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
* LayoutTests/fast/css/background-clip-text-expected.txt:
* LayoutTests/fast/css/background-position-serialize-expected.txt:
* LayoutTests/fast/css/border-shorthand-initialize-longhands-expected.txt:
* LayoutTests/fast/css/longhand-overrides-shorthand-prefixing-expected.txt:
* LayoutTests/fast/css/parsing-text-emphasis-expected.txt:
* LayoutTests/fast/css/remove-shorthand-expected.txt:
* LayoutTests/fast/css/shorthand-mismatched-list-crash-expected.txt:
* LayoutTests/fast/css/transform-inline-style-expected.txt:
* LayoutTests/fast/css/transform-inline-style-remove-expected.txt:
* LayoutTests/fast/dom/background-shorthand-csstext-expected.txt:
* LayoutTests/fast/masking/parsing-mask-expected.txt:
* LayoutTests/fast/masking/parsing-webkit-mask-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/content-security-policy/style-src/inline-style-allowed-while-cloning-objects.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-shorthand-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-position-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-valid.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/column-rule-shorthand-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cssText-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/border-shorthand-serialization-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-values-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/shorthand-values-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-valid.sub-expected.txt:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/StyleProperties.cpp:
(WebCore::StyleProperties::commonShorthandChecks const):
(WebCore::StyleProperties::getPropertyValue const):
(WebCore::StyleProperties::get2Values const):
(WebCore::StyleProperties::get4Values const):
(WebCore::StyleProperties::getLayeredShorthandValue const):
(WebCore::StyleProperties::borderImagePropertyValue const):
(WebCore::StyleProperties::borderPropertyValue const):
(WebCore::StyleProperties::breakInsideShorthandValue const):
(WebCore::StyleProperties::pageBreakValue const):
(WebCore::StyleProperties::webkitColumnBreakValue const):
(WebCore::canUseShorthandForLonghand):
(WebCore::isValueID): Deleted.
(WebCore::isPair): Deleted.
(WebCore::StyleProperties::hasAllInitialValues const): Deleted.
* Source/WebCore/css/StyleProperties.h:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::addExpandedPropertyForValue):
(WebCore::CSSPropertyParser::parseValueStart):
(WebCore::CSSPropertyParser::consumeCSSWideKeyword):
(WebCore::CSSPropertyParser::consumeShorthandGreedily):
(WebCore::CSSPropertyParser::consumeBorder):
(WebCore::CSSPropertyParser::consumeBorderImage):
(WebCore::CSSPropertyParser::consumeAnimationShorthand):
(WebCore::CSSPropertyParser::consumeBackgroundShorthand):
(WebCore::CSSPropertyParser::parseShorthand):
(WebCore::CSSPropertyParser::addExpandedProperty): Deleted.
(WebCore::CSSPropertyParser::addExpandedPropertyWithImplicitDefault): Deleted.
(): Deleted.
(WebCore::initialValueForLonghand): Deleted.
(WebCore::initialCSSValueForLonghand): Deleted.
(WebCore::isNumber): Deleted.
(WebCore::pairValue): Deleted.
(WebCore::quadValue): Deleted.
(WebCore::isValueIDPair): Deleted.
(WebCore::isNumericQuad): Deleted.
(WebCore::isInitialValueForLonghand): Deleted.
(WebCore::initialValueTextForLonghand): Deleted.
(WebCore::CSSPropertyParser::consumeBorderShorthand): Deleted.
* Source/WebCore/css/parser/CSSPropertyParser.h:

Canonical link: https://commits.webkit.org/258087@main




More information about the webkit-changes mailing list