[webkit-changes] [WebKit/WebKit] 87ae77: [JSC] Use ExtendedOffsetAddr if normal Addr with S...
Yusuke Suzuki
noreply at github.com
Mon Dec 19 10:33:41 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 87ae77e616dd6d6cfeb1bece78f2ac9482e132fa
https://github.com/WebKit/WebKit/commit/87ae77e616dd6d6cfeb1bece78f2ac9482e132fa
Author: Yusuke Suzuki <ysuzuki at apple.com>
Date: 2022-12-19 (Mon, 19 Dec 2022)
Changed paths:
M Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp
Log Message:
-----------
[JSC] Use ExtendedOffsetAddr if normal Addr with SP/FP failed for Patch
https://bugs.webkit.org/show_bug.cgi?id=249553
rdar://103492366
Reviewed by Justin Michaud.
Patchpoint requires that all stack arguments needs to be represented as "SP + offset" or "FP + offset".
But in AirLowerStackArgs, we are incorrectly lowering this to "LR + offset" if offset is too large.
We should use a bit suboptimal ExtendedOffsetAddr for that case to ensure that they are still "FP + offset" form.
This fixes debug assertion failure in call.wast.js, happening after 257974 at main.
* Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp:
(JSC::B3::Air::lowerStackArgs):
Canonical link: https://commits.webkit.org/258083@main
More information about the webkit-changes
mailing list