[webkit-changes] [WebKit/WebKit] 05f693: legend.focus() should not delegate focus

Ahmad Saleem noreply at github.com
Mon Dec 19 00:43:24 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05f693e31a84e598a51d00bf3505f1e10049bbc5
      https://github.com/WebKit/WebKit/commit/05f693e31a84e598a51d00bf3505f1e10049bbc5
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-12-19 (Mon, 19 Dec 2022)

  Changed paths:
    M LayoutTests/fast/forms/access-key-expected.txt
    M LayoutTests/fast/forms/focus-expected.txt
    M LayoutTests/fast/forms/focus-selection-input-expected.txt
    M LayoutTests/fast/forms/focus-selection-input.html
    M LayoutTests/fast/forms/focus-selection-textarea-expected.txt
    M LayoutTests/fast/forms/focus.html
    R LayoutTests/fast/forms/legend-access-key-expected.txt
    R LayoutTests/fast/forms/legend-access-key.html
    M LayoutTests/imported/w3c/web-platform-tests/html/interaction/focus/processing-model/legend-expected.txt
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/win/TestExpectations
    M Source/WebCore/html/HTMLLegendElement.cpp
    M Source/WebCore/html/HTMLLegendElement.h

  Log Message:
  -----------
  legend.focus() should not delegate focus

legend.focus() should not delegate focus
https://bugs.webkit.org/show_bug.cgi?id=189242

Reviewed by Ryosuke Niwa.

This patch is to align Webkit with Blink / Chromium, Gecko / Firefox and Web-Specification.

Web-Spec Discussion Issue - https://github.com/whatwg/html/issues/3950

Merge - https://chromium.googlesource.com/chromium/src.git/+/2010bba41812ac1f3ea92a286c3894a14535766e

This patch removes focus delegation and accesskey from the legend element to align with Web-Specification.

* Source/WebCore/html/HTMLLegendElement.h:
(1) Remove "HTMLFormControlElement" class
(2) Remove "associatedControl", "accessKeyActions" and "focus" function
* Source/WebCore/html/HTMLLegendElement.cpp:
(HTMLLegendElement::associatedControl): Deleted
(HTMLLegendElement::focus): Ditto
(HTMLLegendElement::accessKeyAction): Ditto
* LayoutTests/fast/form/legend-access-key.html: Deleted
* LayoutTests/fast/form/legend-access-key-expected.txt: Deleted
* LayoutTests/fast/form/focus.html: Updated
* LayoutTests/fast/form/focus-expected.txt: Ditto
* LayoutTests/fast/forms/focus-selection-textarea-expected.txt: Ditto
* LayoutTests/fast/forms/focus-selection-input.html: Ditto
* LayoutTests/fast/forms/focus-selection-input-expected.txt: Ditto
* LayoutTests/fast/form/access-key-expected.txt: Ditto
* LayoutTests/imported/w3c/web-platform-tests/html/interaction/focus/processing-model/legend-expected.html: Rebaselined
* LayoutTests/platform/ios/TestExpectations: Remove 'deleted' testcase expectation
* LayoutTests/platform/win/TestExpectations: Remove 'deleted' testcase expectation

Canonical link: https://commits.webkit.org/258074@main




More information about the webkit-changes mailing list