[webkit-changes] [WebKit/WebKit] 411200: Live Text is visible after hovering on images in g...

Wenson Hsieh noreply at github.com
Sat Dec 17 16:14:44 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4112008b949ffffd7238a40e23674f621983c5e1
      https://github.com/WebKit/WebKit/commit/4112008b949ffffd7238a40e23674f621983c5e1
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2022-12-17 (Sat, 17 Dec 2022)

  Changed paths:
    A LayoutTests/fast/images/text-recognition/image-overlay-with-text-fill-and-stroke-expected.html
    A LayoutTests/fast/images/text-recognition/image-overlay-with-text-fill-and-stroke.html
    M Source/WebCore/html/shadow/imageOverlay.css

  Log Message:
  -----------
  Live Text is visible after hovering on images in gentlemencoders.com
https://bugs.webkit.org/show_bug.cgi?id=249540
rdar://102196692

Reviewed by Ryosuke Niwa.

Make a small adjustment to the image overlay stylesheet, to prevent explicitly set
`-webkit-text-{fill|stroke}-color` in image elements from causing injected Live Text to show up as
non-transparent text.

Note that we use `currentcolor` here instead of `transparent`, so that text in image overlays for
visual translation *will* continue to show up as visible text (against semi-transparent backdrop
containers).

* LayoutTests/fast/images/text-recognition/image-overlay-with-text-fill-and-stroke-expected.html: Added.
* LayoutTests/fast/images/text-recognition/image-overlay-with-text-fill-and-stroke.html: Added.
* Source/WebCore/html/shadow/imageOverlay.css:
(div#image-overlay):

Canonical link: https://commits.webkit.org/258057@main




More information about the webkit-changes mailing list