[webkit-changes] [WebKit/WebKit] 2ad3df: [Live Range Selection] image overlay tests fail

Ryosuke Niwa noreply at github.com
Sat Dec 17 05:41:19 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ad3dff89d32c62d36ddb3e93b18cfd5be580fa9
      https://github.com/WebKit/WebKit/commit/2ad3dff89d32c62d36ddb3e93b18cfd5be580fa9
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-12-17 (Sat, 17 Dec 2022)

  Changed paths:
    M LayoutTests/fast/images/text-recognition/image-overlay-block-with-newlines-expected.txt
    M LayoutTests/fast/images/text-recognition/image-overlay-block-with-newlines.html
    M LayoutTests/fast/images/text-recognition/image-overlay-line-wrapping.html
    M LayoutTests/fast/images/text-recognition/image-overlay-reversed-range-expected.txt
    M LayoutTests/fast/images/text-recognition/image-overlay-reversed-range.html
    M LayoutTests/fast/images/text-recognition/image-overlay-text-without-leading-whitespace.html

  Log Message:
  -----------
  [Live Range Selection] image overlay tests fail
https://bugs.webkit.org/show_bug.cgi?id=249529

Reviewed by Darin Adler.

These image overlay tests start fail when enabling live range selection because they rely on
getSelection().selectAllChildren to be able to select contents within user-agent shadow roots.

Some tests also rely on getSelection().toString() to include the same selected content.

Fixed these tests by using internals.setSelectionWithoutValidation to select the contents
within user-agent shadow roots, and copying & pasting it to textarea / input element
to extract the selected txt.

* LayoutTests/fast/images/text-recognition/image-overlay-block-with-newlines-expected.txt:
* LayoutTests/fast/images/text-recognition/image-overlay-block-with-newlines.html:
* LayoutTests/fast/images/text-recognition/image-overlay-line-wrapping.html:
* LayoutTests/fast/images/text-recognition/image-overlay-reversed-range-expected.txt:
* LayoutTests/fast/images/text-recognition/image-overlay-reversed-range.html:
* LayoutTests/fast/images/text-recognition/image-overlay-text-without-leading-whitespace.html:

Canonical link: https://commits.webkit.org/258041@main




More information about the webkit-changes mailing list