[webkit-changes] [WebKit/WebKit] c19143: [JSC] Tuple should be able to include V128 constant

Yusuke Suzuki noreply at github.com
Fri Dec 16 21:34:18 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c19143329472ea9a6735cae49b3c11f87c373947
      https://github.com/WebKit/WebKit/commit/c19143329472ea9a6735cae49b3c11f87c373947
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-12-16 (Fri, 16 Dec 2022)

  Changed paths:
    A JSTests/wasm/stress/resources/tuple-and-v128.wasm
    A JSTests/wasm/stress/tuple-and-simd.js
    A JSTests/wasm/stress/tuple-and-v128.js
    M Source/JavaScriptCore/b3/B3Procedure.cpp
    M Source/JavaScriptCore/wasm/WasmAirIRGenerator32_64.cpp
    M Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp
    M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h
    M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp

  Log Message:
  -----------
  [JSC] Tuple should be able to include V128 constant
https://bugs.webkit.org/show_bug.cgi?id=249378
rdar://103392110

Reviewed by Justin Michaud.

This patch implements wasm Tuple including V128 constant.
To make it work,

1. We extend Bottom value generation to support V128.
2. We add B3 IR generator constant with 0xbbadbeef generation for V128.

* JSTests/wasm/stress/resources/tuple-and-v128.wasm: Added.
* JSTests/wasm/stress/tuple-and-simd.js: Added.
(assert.throws):
* JSTests/wasm/stress/tuple-and-v128.js: Added.
(let.importObject.m.ifn0):
(async let):
* Source/JavaScriptCore/b3/B3Procedure.cpp:
(JSC::B3::Procedure::addBottom):
* Source/JavaScriptCore/wasm/WasmAirIRGenerator32_64.cpp:
(JSC::Wasm::AirIRGenerator32::emitZeroInitialize):
(JSC::Wasm::AirIRGenerator32::addConstantZero):
(JSC::Wasm::AirIRGenerator64::addConstantZero):
* Source/JavaScriptCore/wasm/WasmAirIRGenerator64.cpp:
(JSC::Wasm::AirIRGenerator64::emitZeroInitialize):
(JSC::Wasm::AirIRGenerator64::addConstant):
(JSC::Wasm::AirIRGenerator64::addConstantZero):
* Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h:
(JSC::Wasm::ExpressionType>::addBottom):
(JSC::Wasm::ExpressionType>::addConstantZero):
* Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::constant):

Canonical link: https://commits.webkit.org/258034@main




More information about the webkit-changes mailing list