[webkit-changes] [WebKit/WebKit] 90112a: Stop allowing numbers during parsing of cx, cy, x, ...

Chris Dumez noreply at github.com
Fri Dec 16 18:35:53 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 90112a7d702fa28ce9886a5b0ca62ff2edb9d708
      https://github.com/WebKit/WebKit/commit/90112a7d702fa28ce9886a5b0ca62ff2edb9d708
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-12-16 (Fri, 16 Dec 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/center-coordinate-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/coordinate-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/geometry/parsing/cx-invalid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/geometry/parsing/cy-invalid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/geometry/parsing/x-invalid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/geometry/parsing/y-invalid-expected.txt
    M Source/WebCore/css/CSSProperties.json

  Log Message:
  -----------
  Stop allowing numbers during parsing of cx, cy, x, y CSS properties
https://bugs.webkit.org/show_bug.cgi?id=249479

Reviewed by Sam Weinig.

Stop allowing numbers during parsing of cx, cy, x, y CSS properties.

Per the specification, we should allow <length-percentage>, not <number>:
- https://svgwg.org/svg2-draft/geometry.html#CX
- https://svgwg.org/svg2-draft/geometry.html#CY
- https://svgwg.org/svg2-draft/geometry.html#X
- https://svgwg.org/svg2-draft/geometry.html#Y

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/center-coordinate-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/coordinate-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/geometry/parsing/cx-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/geometry/parsing/cy-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/geometry/parsing/x-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/geometry/parsing/y-invalid-expected.txt:
Rebaseline WPT tests now that more checks are passing.

* Source/WebCore/css/CSSProperties.json:
Use <length-percentage> instead of <length-percentage svg> for the parser grammar,
since the svg attribute parsing mode allows unitless values.

Canonical link: https://commits.webkit.org/258029@main




More information about the webkit-changes mailing list