[webkit-changes] [WebKit/WebKit] 5c1483: CSS Keywords should be lowercased during serializa...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5c14835fdcfe302f7e5b85d732ab092676799325
      https://github.com/WebKit/WebKit/commit/5c14835fdcfe302f7e5b85d732ab092676799325
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-12-16 (Fri, 16 Dec 2022)

  Changed paths:
    M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
    M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
    M LayoutTests/fast/css/image-rendering-parsing-expected.txt
    M LayoutTests/fast/css/image-rendering-parsing.html
    M LayoutTests/fast/css/parsing-text-rendering-expected.txt
    M LayoutTests/fast/css/resources/parsing-text-rendering.js
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/color-interpolation-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/pointer-events-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-rendering-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-rendering-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/inheritance-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/parsing/color-interpolation-filters-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/parsing/color-interpolation-filters-parsing-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/interact/parsing/pointer-events-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/painting/inheritance-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/color-interpolation-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/image-rendering-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/image-rendering-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/shape-rendering-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/shape-rendering-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/text-rendering-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/text-rendering-valid-expected.txt
    M LayoutTests/svg/css/getComputedStyle-basic-expected.txt
    M LayoutTests/svg/css/shape-rendering-parsing-expected.txt
    M LayoutTests/svg/css/shape-rendering-parsing.html
    M Source/WebCore/css/CSSPrimitiveValue.cpp
    M Source/WebCore/css/process-css-values.py
    M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp

  Log Message:
  -----------
  CSS Keywords should be lowercased during serialization
https://bugs.webkit.org/show_bug.cgi?id=249438

Reviewed by Sam Weinig.

CSS Keywords should be lowercased during serialization:
- https://www.w3.org/TR/cssom-1/#serialize-a-css-component-value

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/color-interpolation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/pointer-events-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/shape-rendering-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-rendering-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/inheritance-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/parsing/color-interpolation-filters-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/parsing/color-interpolation-filters-parsing-valid-expected.txt:
Rebaseline WPT tests now that more checks are passing.

* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const):
Call nameStringForSerialization() instead of nameString() since we are serializing.
This makes sure that the identifier is serialized as lowercase.

* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::CSSStyleValueFactory::reifyValue):
Per https://drafts.css-houdini.org/css-typed-om-1/#reify-ident, we should create
a CSSKeywordValue from the *serialization* of the identifier, which means that
the identifier would become lowercase.

* Source/WebCore/css/process-css-values.py:
(GenerationContext):
Generate nameStringForSerialization() which provides the name string of the
keyword as lowercase, for the purpose of serialization.

Canonical link: https://commits.webkit.org/258024@main