[webkit-changes] [WebKit/WebKit] 9de680: ASSERTION FAILED in ~GraphicsContextGLTextureMappe...

Fujii Hironori noreply at github.com
Fri Dec 16 15:05:40 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9de68063d5f0bbe83386a36561643d2d5b6ef27d
      https://github.com/WebKit/WebKit/commit/9de68063d5f0bbe83386a36561643d2d5b6ef27d
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2022-12-16 (Fri, 16 Dec 2022)

  Changed paths:
    M Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp

  Log Message:
  -----------
  ASSERTION FAILED in ~GraphicsContextGLTextureMapperANGLE
https://bugs.webkit.org/show_bug.cgi?id=249449

Reviewed by Kimmo Kinnunen.

WinCairo WK2 Debug was reporting an assertion failure for
webgl/webgl-fail-platform-context-creation-no-crash.html. The
assertion assumed makeContextCurrent() always succeeded. But, it's not
true. It should check the return value like Cocoa port does.

* Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::~GraphicsContextGLANGLE):
(WebCore::GraphicsContextGLTextureMapperANGLE::~GraphicsContextGLTextureMapperANGLE):

Canonical link: https://commits.webkit.org/258021@main




More information about the webkit-changes mailing list