[webkit-changes] [WebKit/WebKit] f93a35: Fix testapi to work with JITCage and LLInt only runs.

EWS noreply at github.com
Fri Dec 16 11:23:47 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f93a35064d8090d4875d5fd62e44cafa1b3da44a
      https://github.com/WebKit/WebKit/commit/f93a35064d8090d4875d5fd62e44cafa1b3da44a
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2022-12-16 (Fri, 16 Dec 2022)

  Changed paths:
    M Source/JavaScriptCore/API/tests/ExecutionTimeLimitTest.cpp
    M Source/JavaScriptCore/API/tests/PingPongStackOverflowTest.cpp

  Log Message:
  -----------
  Fix testapi to work with JITCage and LLInt only runs.
https://bugs.webkit.org/show_bug.cgi?id=249475
<rdar://problem/103447329>

Reviewed by Justin Michaud.

1. Fix PingPongStackOverflowTest to handle the case where the JIT is disable.
   It should not force disable the LLInt if the JIT is not available.

2. Fix ExecutionTimeLimitTest tier options to use Options::useBaselineJIT(), instead of
   Options::useJIT(), to determine whether the baseline JIT is enabled of not.  The value
   of Options::useJIT() is determined at launch and already puts in place infrastructure
   that assumes either the JIT is enabled or not.  As a result, it should never be changed
   at runtime.  This especially impacts runs with the JITCage enabled which installs JIT
   thunks that expect JITCage conformant behavior.

3. Fix ExecutionTimeLimitTest to not run the test with JIT tiers if JIT'ing is disabled.

* Source/JavaScriptCore/API/tests/ExecutionTimeLimitTest.cpp:
(testExecutionTimeLimit):
* Source/JavaScriptCore/API/tests/PingPongStackOverflowTest.cpp:
(testPingPongStackOverflow):

Canonical link: https://commits.webkit.org/258007@main




More information about the webkit-changes mailing list