[webkit-changes] [WebKit/WebKit] 05e5d9: Refactor marked text painting logic

Richard Robinson noreply at github.com
Fri Dec 16 09:45:30 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05e5d958017a00b89ab34993fb9c96819b98d839
      https://github.com/WebKit/WebKit/commit/05e5d958017a00b89ab34993fb9c96819b98d839
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2022-12-16 (Fri, 16 Dec 2022)

  Changed paths:
    M Source/WebCore/rendering/TextBoxPainter.cpp
    M Source/WebCore/rendering/TextBoxPainter.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  -----------
  Refactor marked text painting logic
https://bugs.webkit.org/show_bug.cgi?id=249118
rdar://101869724

Reviewed by Aditya Keerthi and Tim Horton.

* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter<TextBoxPath>::colorForUnderline const):
(WebCore::TextBoxPainter<TextBoxPath>::paintCompositionUnderline):
* Source/WebCore/rendering/TextBoxPainter.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _setCompositionForMarkedTextWithHighlights:selectedRange:]):
(-[WKContentView _setMarkedText:highlights:selectedRange:]):

Canonical link: https://commits.webkit.org/258001@main




More information about the webkit-changes mailing list