[webkit-changes] [WebKit/WebKit] f89806: Don't auto-wrap 'svg:text'

Ahmad Saleem noreply at github.com
Fri Dec 16 08:56:58 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f89806418b17c817c6be33774b1394a1fd846a06
      https://github.com/WebKit/WebKit/commit/f89806418b17c817c6be33774b1394a1fd846a06
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-12-16 (Fri, 16 Dec 2022)

  Changed paths:
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-001-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-003-expected.txt
    M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-002-expected.txt
    M LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-001-expected.txt
    M LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-002-expected.txt
    M LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-003-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-001-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-002-expected.txt
    M LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-003-expected.txt
    A LayoutTests/svg/text/white-space-no-autowrap-expected.html
    A LayoutTests/svg/text/white-space-no-autowrap.html
    M Source/WebCore/rendering/line/BreakingContext.h

  Log Message:
  -----------
  Don't auto-wrap 'svg:text'

Don't auto-wrap 'svg:text'
https://bugs.webkit.org/show_bug.cgi?id=249300

Reviewed by Simon Fraser.

This patch is to align Webkit with Gecko / Firefox and Blink / Chromium.

Merge - https://src.chromium.org/viewvc/blink?revision=196298&view=revision

Even if an explicit 'white-space' property overrides the presentation
attribute style (from 'xml:space'), auto-wrap should still be disabled.

* Source/WebCore/rendering/line/BreakingContext.h:
(BreakingContext::initializeForCurrentObject):
(1) Add bool 'isSVGText'
(2) Use 'isSVGText" for m_autoWrap to disable on SVG Text
(3) Update 'm_preservesNewline' to use new bool 'isSVGText'
* LayoutTests/svg/text/white-space-no-autowrap.html: Add Test Case
* LayoutTests/svg/text/white-space-no-autowrap-expected.html: Add Test Case Expectation
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-001-expected.txt: Updated Test Expectations
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-003-expected.txt: Ditto
* LayoutTests/platform/gtk-wk2/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-002-expected.txt: Ditto
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-001-expected.txt: Ditto
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-002-expected.txt: Ditto
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/svg/text/reftests/text-multiline-003-expected.txt: Ditto
* LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/text/reftest/text-multiline-001-expected.txt: Ditto
* LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/text/reftest/text-multiline-002-expected.txt: Ditto
* LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/svg/text/reftest/text-multiline-003-expected.txt: Ditto

Canonical link: https://commits.webkit.org/257993@main




More information about the webkit-changes mailing list