[webkit-changes] [WebKit/WebKit] 24540c: REGRESSION(205039 at main): StyledMarkupAccumulator s...

Ryosuke Niwa noreply at github.com
Thu Dec 15 22:12:46 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 24540c7a6767717f61a5423cbf468b162bd1b88a
      https://github.com/WebKit/WebKit/commit/24540c7a6767717f61a5423cbf468b162bd1b88a
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-12-15 (Thu, 15 Dec 2022)

  Changed paths:
    A LayoutTests/editing/pasteboard/copy-content-with-display-none-exiting-ancestors-expected.txt
    A LayoutTests/editing/pasteboard/copy-content-with-display-none-exiting-ancestors.html
    M Source/WebCore/editing/markup.cpp

  Log Message:
  -----------
  REGRESSION(205039 at main): StyledMarkupAccumulator sometimes does not emit an end tag
https://bugs.webkit.org/show_bug.cgi?id=249426

Reviewed by Wenson Hsieh.

The bug was caused by traverseNodesForSerialization failing to register ancestors that climbed out of
when enterNode returns false. Fixed the bug by re-using the normal traversal code.

* LayoutTests/editing/pasteboard/copy-content-with-display-none-exiting-ancestors-expected.txt: Added.
* LayoutTests/editing/pasteboard/copy-content-with-display-none-exiting-ancestors.html: Added.
* Source/WebCore/editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization):

Canonical link: https://commits.webkit.org/257977@main




More information about the webkit-changes mailing list