[webkit-changes] [WebKit/WebKit] 40bfa0: AX: Control value is not updated after dynamic cha...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 40bfa0c8714b2f1ac59a941988d1c43d353ba891
      https://github.com/WebKit/WebKit/commit/40bfa0c8714b2f1ac59a941988d1c43d353ba891
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2022-12-15 (Thu, 15 Dec 2022)

  Changed paths:
    A LayoutTests/accessibility/color-input-value-changes-expected.txt
    A LayoutTests/accessibility/color-input-value-changes.html
    A LayoutTests/accessibility/progress-element-value-changes-expected.txt
    A LayoutTests/accessibility/progress-element-value-changes.html
    A LayoutTests/accessibility/textarea-value-changes-expected.txt
    A LayoutTests/accessibility/textarea-value-changes.html
    M LayoutTests/platform/glib/TestExpectations
    A LayoutTests/platform/glib/accessibility/color-input-value-changes-expected.txt
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/platform/win/TestExpectations
    M Source/WebCore/html/ColorInputType.cpp
    M Source/WebCore/html/HTMLProgressElement.cpp
    M Source/WebCore/html/HTMLTextAreaElement.cpp

  Log Message:
  -----------
  AX: Control value is not updated after dynamic changes to color inputs, textareas, or progress elements
https://bugs.webkit.org/show_bug.cgi?id=249283
rdar://103272091

Reviewed by Chris Fleizach and Andres Gonzalez.

When textarea elements, progress elements, and type="color" inputs update,
we aren't submitting value changed notifications, which also means we aren't
updating the ITM cache. This patch fixes that.

* LayoutTests/accessibility/color-input-value-changes-expected.txt: Added.
* LayoutTests/accessibility/color-input-value-changes.html: Added.
* LayoutTests/accessibility/progress-element-value-changes-expected.txt: Added.
* LayoutTests/accessibility/progress-element-value-changes.html: Added.
* LayoutTests/accessibility/textarea-value-changes-expected.txt: Added.
* LayoutTests/accessibility/textarea-value-changes.html: Added.
Add tests.

* LayoutTests/platform/glib/TestExpectations:
Skip accessibility/progress-element-value-changes.html because it's timing out.
* LayoutTests/platform/glib/accessibility/color-input-value-changes-expected.txt: Added.
* LayoutTests/platform/mac-wk1/TestExpectations:
Skip accessibility/color-input-value-changes.html because color inputs aren't supported in WK1.
* LayoutTests/platform/win/TestExpectations:
Skip accessibility/color-input-value-changes.html and accessibility/progress-element-value-changes.html.

* Source/WebCore/html/ColorInputType.cpp:
(WebCore::ColorInputType::attributeChanged):
(WebCore::ColorInputType::didChooseColor):
* Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setValueCommon):
* Source/WebCore/html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::didElementStateChange):
Inform the AXObjectCache the control values have changed.

Canonical link: https://commits.webkit.org/257976@main