[webkit-changes] [WebKit/WebKit] 2e52da: Reduce the usage of WheelEventTestMonitor::Scrolla...

Simon Fraser noreply at github.com
Thu Dec 15 18:34:23 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2e52daf4f7c4692209cb86777fe5b7d6b597f288
      https://github.com/WebKit/WebKit/commit/2e52daf4f7c4692209cb86777fe5b7d6b597f288
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2022-12-15 (Thu, 15 Dec 2022)

  Changed paths:
    M Source/WebCore/page/scrolling/ScrollingTree.cpp
    M Source/WebCore/page/scrolling/ScrollingTree.h
    M Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.cpp
    M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h
    M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm

  Log Message:
  -----------
  Reduce the usage of WheelEventTestMonitor::ScrollableAreaIdentifier in the scrolling tree
https://bugs.webkit.org/show_bug.cgi?id=249419
rdar://103411823

Reviewed by Brent Fulgham.

WheelEventTestMonitor::ScrollableAreaIdentifier is an ugly void*, and in scrolling tree code we use
ScrollingNodeIDs as identifiers, so stay with ScrollingNodeIDs for as long as we can.

* Source/WebCore/page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::deferWheelEventTestCompletionForReason):
(WebCore::ScrollingTree::removeWheelEventTestCompletionDeferralForReason):
* Source/WebCore/page/scrolling/ScrollingTree.h:
* Source/WebCore/page/scrolling/ThreadedScrollingTreeScrollingNodeDelegate.cpp:
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::deferWheelEventTestCompletionForReason const):
(WebCore::ThreadedScrollingTreeScrollingNodeDelegate::removeWheelEventTestCompletionDeferralForReason const):
* Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
* Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:
(WebCore::ScrollingTreeScrollingNodeDelegateMac::deferWheelEventTestCompletionForReason const): Deleted. Same as the base class impl.
(WebCore::ScrollingTreeScrollingNodeDelegateMac::removeWheelEventTestCompletionDeferralForReason const): Deleted. Ditto.

Canonical link: https://commits.webkit.org/257971@main




More information about the webkit-changes mailing list