[webkit-changes] [WebKit/WebKit] e603e4: Add margin-trim to CSS parser.
Sammy Gill
noreply at github.com
Thu Dec 15 16:17:46 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e603e43fbb226e2dd51867afc86e6c0a879c800e
https://github.com/WebKit/WebKit/commit/e603e43fbb226e2dd51867afc86e6c0a879c800e
Author: Sammy Gill <sammy.gill at apple.com>
Date: 2022-12-15 (Thu, 15 Dec 2022)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/css/css-box/inheritance-expected.txt
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/parsing/margin-trim-computed-expected.txt
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/parsing/margin-trim-computed.html
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/parsing/margin-trim-expected.txt
A LayoutTests/imported/w3c/web-platform-tests/css/css-box/parsing/margin-trim.html
M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
M Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
M Source/WebCore/animation/CSSPropertyAnimation.cpp
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleConstants.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.h
M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
M Source/WebCore/rendering/style/StyleRareNonInheritedData.h
M Source/WebCore/style/StyleBuilderConverter.h
Log Message:
-----------
Add margin-trim to CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=249205
rdar://103285644
Reviewed by Tim Nguyen.
Creates a feature flag for the margin-trim CSS property and also
adds it to the CSS parser behind this flag. When the flag is enabled the
property can be set according to the grammar in the spec.
This property has the following grammar:
none | block | inline | [ block-start || inline-start || block-end || inline-end ]
Spec reference: https://www.w3.org/TR/css-box-4/#margin-trim
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/parsing/margin-trim-computed-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/parsing/margin-trim-computed.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/parsing/margin-trim-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-box/parsing/margin-trim.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/parser/CSSParserContext.cpp:
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeMarginTrim):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::marginTrim const):
(WebCore::RenderStyle::setMarginTrim):
(WebCore::RenderStyle::initialMarginTrim):
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertMarginTrim):
Canonical link: https://commits.webkit.org/257960@main
More information about the webkit-changes
mailing list