[webkit-changes] [WebKit/WebKit] 37f486: `font-variant-alternates: historical-forms` doesn'...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37f48652e37e505cc21a3a655d024de17fcc02ce
      https://github.com/WebKit/WebKit/commit/37f48652e37e505cc21a3a655d024de17fcc02ce
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-12-15 (Thu, 15 Dec 2022)

  Changed paths:
    A LayoutTests/fast/css/font-variant-alternates-computed-value-expected.txt
    A LayoutTests/fast/css/font-variant-alternates-computed-value.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-alternates-expected.txt
    M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  -----------
  `font-variant-alternates: historical-forms` doesn't reflect properly via StylePropertyMap
https://bugs.webkit.org/show_bug.cgi?id=249337

Reviewed by Tim Nguyen.

`font-variant-alternates: historical-forms` doesn't reflect properly via
StylePropertyMap. Even though `historical-forms` is a supported keyword for
this CSS property [1], we wouldn't get a CSSKeywordValue when reading the
property value back. The issue is that we convert to a FontVariantAlternates
internally and then back to a CSSValue. The function to convert back to a
CSSValue (fontVariantAlternatesPropertyValue) was only handling the `normal`
keyword but not the `historical-forms` one.

[1] https://w3c.github.io/csswg-drafts/css-fonts/#font-variant-alternates-prop

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/font-variant-alternates-expected.txt:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::fontVariantAlternatesPropertyValue):

Canonical link: https://commits.webkit.org/257955@main