[webkit-changes] [WebKit/WebKit] 5015ae: [IFC][Integration] Enable out-of-flow content with...

Alan Baradlay noreply at github.com
Thu Dec 15 10:27:47 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5015aec32c59e9d1dae8904bf9acfeacb9a03b9c
      https://github.com/WebKit/WebKit/commit/5015aec32c59e9d1dae8904bf9acfeacb9a03b9c
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2022-12-15 (Thu, 15 Dec 2022)

  Changed paths:
    M LayoutTests/platform/ios/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt
    M LayoutTests/platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderInline.cpp
    M Source/WebCore/rendering/RenderInline.h

  Log Message:
  -----------
  [IFC][Integration] Enable out-of-flow content with inline box containing box for IFC
https://bugs.webkit.org/show_bug.cgi?id=249370

Reviewed by Antti Koivisto.

This patch adds support for cases when the out-of-flow box's containing block is an inline box
e.g.
<div>
  <span style="position: relative">
    <div style="position: absolute></div>
  </span>
</div>

1. Move inline box logic from RenderBox::containingBlockLogicalWidth/HeightForPositioned to RenderInline
2. Implement the missing IFC support to compute the inner (padding) box of the first and last inline box.
3. Add IFC support in RenderInline::offsetForInFlowPositionedInline

* LayoutTests/platform/mac/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt:
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned const):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned const):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::innerPaddingBoxWidth const):
(WebCore::RenderInline::innerPaddingBoxHeight const):
(WebCore::RenderInline::offsetForInFlowPositionedInline const):
* Source/WebCore/rendering/RenderInline.h:

Canonical link: https://commits.webkit.org/257937@main




More information about the webkit-changes mailing list