[webkit-changes] [WebKit/WebKit] 66c0e8: Allow setting custom identifiers via the CSS Typed...

Chris Dumez noreply at github.com
Wed Dec 14 08:22:07 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 66c0e84643e55fdac3b63d8bac7b958abe0d7120
      https://github.com/WebKit/WebKit/commit/66c0e84643e55fdac3b63d8bac7b958abe0d7120
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-12-14 (Wed, 14 Dec 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-name-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/container-name-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/page-expected.txt
    M Source/WebCore/css/typedom/CSSKeywordValue.cpp

  Log Message:
  -----------
  Allow setting custom identifiers via the CSS Typed OM API
https://bugs.webkit.org/show_bug.cgi?id=249270

Reviewed by Simon Fraser.

Allow setting custom identifiers via the CSS Typed OM API:
- https://drafts.css-houdini.org/css-typed-om/#reify-ident
- https://w3c.github.io/csswg-drafts/css-values-4/#identifier-value

Previously, we would fail to convert the CSSKeywordValue into a CSSValue if
the identifier is a pre-defined keyword. We now construct a <custom-ident>
CSSPrimitiveValue in this case.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/animation-name-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/container-name-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/page-expected.txt:
* Source/WebCore/css/typedom/CSSKeywordValue.cpp:
(WebCore::CSSKeywordValue::toCSSValue const):

Canonical link: https://commits.webkit.org/257859@main




More information about the webkit-changes mailing list