[webkit-changes] [WebKit/WebKit] 11f8b4: Fix css/css-typed-om/stylevalue-serialization/cssT...

Chris Dumez noreply at github.com
Wed Dec 14 01:26:19 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11f8b47f5d1c3327970107382c903b0a8658793d
      https://github.com/WebKit/WebKit/commit/11f8b47f5d1c3327970107382c903b0a8658793d
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-12-14 (Wed, 14 Dec 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html

  Log Message:
  -----------
  Fix css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html WPT test
https://bugs.webkit.org/show_bug.cgi?id=249246

Reviewed by Antoine Quint.

Fix css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html
WPT test. In particular, the test tries to serialize:
`new CSSMathProduct(CSS.deg(1), new CSSMathInvert(new CSSUnitValue(0, 'number')))`

And expects the string:
`calc(1deg * (1 / 0))`

However, per the specification [1], it should be:
`calc(1deg / 0)`

[1] https://drafts.css-houdini.org/css-typed-om-1/#serialize-a-cssmathvalue (step 5)

The previously expected result in the test seemed to come from step 6 in the test
but it doesn't apply here since we're serializing a CSSMathInvert as a child of a
CSSMathProduct. Step 5 is for the serialization of a CSSMathProduct and has special
handling when a child is a CSSMathInvert.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-serialization/cssTransformValue.tentative.html:

Canonical link: https://commits.webkit.org/257839@main




More information about the webkit-changes mailing list