[webkit-changes] [WebKit/WebKit] e9e73c: Use RefPtr and WeakPtr with WebProcessProxy in mor...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e9e73c9aa4924d641f9b7a50562518010e02e075
      https://github.com/WebKit/WebKit/commit/e9e73c9aa4924d641f9b7a50562518010e02e075
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2022-12-13 (Tue, 13 Dec 2022)

  Changed paths:
    M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Source/WebKit/UIProcess/WebBackForwardCache.cpp
    M Source/WebKit/UIProcess/WebBackForwardCacheEntry.cpp
    M Source/WebKit/UIProcess/WebBackForwardCacheEntry.h
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.h

  Log Message:
  -----------
  Use RefPtr and WeakPtr with WebProcessProxy in more places
https://bugs.webkit.org/show_bug.cgi?id=249256
<rdar://103318611>

Reviewed by Alex Christensen and Geoffrey Garen.

Replace uses of raw pointers for WebProcessProxy with RefPtr<>
and WeakPtr<>.  Started by adding a `using WebProcessProxyMap`
statement in WebProcessProxy.h to make it use a WeakPtr<>, then
continued pulling "the thread" to change other uses of raw
pointers.

Most changes below are the result of changing a few methods to
return RefPtr<> instead of a raw pointer and to add nullptr
checks.  Note that allProcesses() was renamed to allProcessMap()
and a new allProcesses() method was created that returns a
Vector<RefPtr<>> to replace uses of allProcesses().values().

* Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::terminateWebProcess):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::terminateWebProcess):
(WebKit::NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses):
(WebKit::NetworkProcessProxy::registerRemoteWorkerClientProcess):
(WebKit::NetworkProcessProxy::unregisterRemoteWorkerClientProcess):
(WebKit::NetworkProcessProxy::remoteWorkerContextConnectionNoLongerNeeded):
(WebKit::NetworkProcessProxy::startServiceWorkerBackgroundProcessing):
(WebKit::NetworkProcessProxy::endServiceWorkerBackgroundProcessing):
(WebKit::NetworkProcessProxy::setWebProcessHasUploads):
(WebKit::NetworkProcessProxy::navigateServiceWorkerClient):
* Source/WebKit/UIProcess/WebBackForwardCache.cpp:
(WebKit::WebBackForwardCache::removeEntriesForSession):
* Source/WebKit/UIProcess/WebBackForwardCacheEntry.cpp:
(WebKit::WebBackForwardCacheEntry::~WebBackForwardCacheEntry):
(WebKit::WebBackForwardCacheEntry::process const):
* Source/WebKit/UIProcess/WebBackForwardCacheEntry.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::processForNavigationInternal):
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::allProcessMap): Add.
(WebKit::WebProcessProxy::allProcesses):
- Update to return Vector<RefPtr<WebProcessProxy>>.
(WebKit::WebProcessProxy::processForIdentifier):
(WebKit::m_webPermissionController):
(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::notifyHasMouseDeviceChanged):
(WebKit::WebProcessProxy::notifyHasStylusDeviceChanged):
* Source/WebKit/UIProcess/WebProcessProxy.h:

Canonical link: https://commits.webkit.org/257828@main