[webkit-changes] [WebKit/WebKit] 5da6fc: Potential Crash fix by making InsertListCommand ch...

Ahmad Saleem noreply at github.com
Tue Dec 13 13:37:28 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5da6fc9173aa1c247933d258be719598554a7d90
      https://github.com/WebKit/WebKit/commit/5da6fc9173aa1c247933d258be719598554a7d90
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-12-13 (Tue, 13 Dec 2022)

  Changed paths:
    A LayoutTests/editing/execCommand/insert-ordered-list-crash2-expected.txt
    A LayoutTests/editing/execCommand/insert-ordered-list-crash2.html
    M Source/WebCore/editing/InsertListCommand.cpp

  Log Message:
  -----------
  Potential Crash fix by making InsertListCommand check endingSelection() editabilitybuild fix

Potential Crash fix by making InsertListCommand check endingSelection() editability
https://bugs.webkit.org/show_bug.cgi?id=249039

Reviewed by Ryosuke Niwa.

Merge - https://src.chromium.org/viewvc/blink?revision=200709&view=revision

This patch is to add early return condition to endOfSelection whether it has
rootEditableElement since L177 does not take assumption about this via endingSelection() in endOfSelection.

* Source/WebCore/editing/InsertListCommand.cpp:
(InsertListCommand::doApply): Add early return about "rootEditableElement"
* LayoutTests/editing/execCommand/insert-ordered-list-crash2.html: Add Test Case
* LayoutTests/editing/execCommand/insert-ordered-list-crash2-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/257811@main




More information about the webkit-changes mailing list