[webkit-changes] [WebKit/WebKit] ec532a: [IFC][line clamp] Only truncate clamped line when ...
Alan Baradlay
noreply at github.com
Tue Dec 13 11:17:06 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ec532a014552f8653ff4d9aab97fe06288738723
https://github.com/WebKit/WebKit/commit/ec532a014552f8653ff4d9aab97fe06288738723
Author: Alan Baradlay <zalan at apple.com>
Date: 2022-12-13 (Tue, 13 Dec 2022)
Changed paths:
A LayoutTests/fast/block/line-clamp-when-no-block-direction-overflow-expected.html
A LayoutTests/fast/block/line-clamp-when-no-block-direction-overflow.html
M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
Log Message:
-----------
[IFC][line clamp] Only truncate clamped line when it overflows in block direction
https://bugs.webkit.org/show_bug.cgi?id=249201
Reviewed by Antti Koivisto.
LineEndingEllipsisPolicy::Always is reserved for the (not yet supported) cases when
ellipsis and truncation should be applied even on the last line of the IFC.
It covers cases when the line-clamp falls on the last line of the IFC while there are
further lines inside the clamped block (e.g. sibling IFC produces some more inline content).
* LayoutTests/fast/block/line-clamp-when-no-block-direction-overflow-expected.html: Added.
* LayoutTests/fast/block/line-clamp-when-no-block-direction-overflow.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::lineEndingEllipsisPolicy):
(WebCore::Layout::InlineFormattingContext::lineLayout):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::close):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:
Canonical link: https://commits.webkit.org/257803@main
More information about the webkit-changes
mailing list