[webkit-changes] [WebKit/WebKit] 174814: [macOS] Add support for theming native controls us...

Aditya Keerthi noreply at github.com
Tue Dec 13 09:06:18 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 174814803dcd46a72695730e8994155008f0e034
      https://github.com/WebKit/WebKit/commit/174814803dcd46a72695730e8994155008f0e034
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2022-12-13 (Tue, 13 Dec 2022)

  Changed paths:
    M Source/WTF/wtf/PlatformUse.h
    M Source/WebCore/PAL/pal/spi/mac/NSViewSPI.h
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/platform/mac/ThemeMac.h
    M Source/WebCore/platform/mac/ThemeMac.mm
    M Source/WebKit/Shared/WebPageCreationParameters.cpp
    M Source/WebKit/Shared/WebPageCreationParameters.h
    M Source/WebKit/UIProcess/API/mac/WKView.mm
    M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
    M Source/WebKit/UIProcess/PageClient.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/mac/PageClientImplMac.h
    M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
    M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
    M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  -----------
  [macOS] Add support for theming native controls using NSViewSemanticContext
https://bugs.webkit.org/show_bug.cgi?id=248764
rdar://99309431

Reviewed by Wenson Hsieh and Tim Horton.

Allow clients to customize the appearance of controls using the web view’s
semantic context. This functionality is achieved by adding support for
`-[WKWebView _setSemanticContext]`, which is existing `NSView` SPI.

Support is restricted to `NSViewSemanticContextForm`, as other contexts do not
apply to web views.

* Source/WTF/wtf/PlatformUse.h:

Add a USE() macro rather than a HAVE() macro, since `NSViewSemanticContextForm`
is only available on macOS 13, even though `NSViewSemanticContext` is available
on older macOS. Consequently, the entire `NSViewSemanticContext` is only being
*used* on macOS 13, as WKWebView support is restricted to form semantic contexts.

* Source/WebCore/PAL/pal/spi/mac/NSViewSPI.h:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/mac/ThemeMac.h:
* Source/WebCore/platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::ensuredView):
(WebCore::ThemeMac::setUseFormSemanticContext):
* Source/WebKit/Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/UIProcess/API/mac/WKView.mm:
(-[WKView _setSemanticContext:]):
* Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:
(-[WKWebView _setSemanticContext:]):
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/mac/PageClientImplMac.h:
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::useFormSemanticContext const):
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:

Remove a redundant `#if PLATFORM(MAC)`.

(WebKit::WebPageProxy::useFormSemanticContext const):
(WebKit::WebPageProxy::semanticContextDidChange):
(WebKit::WebPageProxy::colorSpace):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::useFormSemanticContext const):
(WebKit::WebViewImpl::semanticContextDidChange):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setUseFormSemanticContext):
(WebKit::WebPage::semanticContextDidChange):

Canonical link: https://commits.webkit.org/257792@main




More information about the webkit-changes mailing list