[webkit-changes] [WebKit/WebKit] b9d802: Debug build fixes with assertions disabled

[Claudio Saavedra]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b9d802d8c6456d7cd603897751af94c900431f30
      https://github.com/WebKit/WebKit/commit/b9d802d8c6456d7cd603897751af94c900431f30
  Author: Claudio Saavedra <csaavedra at igalia.com>
  Date:   2022-12-13 (Tue, 13 Dec 2022)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGCSEPhase.cpp
    M Source/WTF/wtf/FastMalloc.cpp
    M Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp
    M Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/layout/formattingContexts/FormattingContext.cpp
    M Source/WebCore/loader/cache/CachedResource.cpp
    M Source/WebCore/platform/PODRedBlackTree.h
    M Source/WebCore/platform/audio/FFTFrame.cpp
    M Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp
    M Source/WebCore/platform/graphics/Font.cpp
    M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
    M Source/WebCore/rendering/RenderFragmentedFlow.cpp
    M Source/WebCore/rendering/RenderInline.cpp
    M Source/WebCore/rendering/RenderTableSection.cpp
    M Source/WebCore/rendering/svg/RenderSVGText.cpp

  Log Message:
  -----------
  Debug build fixes with assertions disabled
https://bugs.webkit.org/show_bug.cgi?id=249129

Reviewed by Philippe Normand.

When disabling assertions in a Debug build there are
plenty of unused variables that break the build due
to -Werror. Most of those are due to using NDEBUG
when ASSERT_ENABLED is needed. Fix those.

* Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:
* Source/WTF/wtf/FastMalloc.cpp:
* Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::clearObjectStore):
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::validateSDP const):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::notificationPostTimerFired):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::detachRemoteParts):
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::removedLastRef):
* Source/WebCore/layout/formattingContexts/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):
* Source/WebCore/loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
* Source/WebCore/platform/PODRedBlackTree.h:
* Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::CDMFactoryClearKey::createCDM):
(WebCore::CDMInstanceSessionClearKey::loadSession):
(WebCore::CDMInstanceSessionClearKey::removeSessionData):
* Source/WebCore/platform/graphics/Font.cpp:
(WebCore::codePointSupportIndex):
* Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::handleErrorConditionFromStreamingThread):
* Source/WebCore/rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::removeRenderBoxFragmentInfo):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRect const):
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):
* Source/WebCore/rendering/svg/RenderSVGText.cpp:
(WebCore::checkLayoutAttributesConsistency):

Canonical link: https://commits.webkit.org/257784@main