[webkit-changes] [WebKit/WebKit] 7e04c0: Add some notifications related WKWebsiteDataStoreD...

Brady Eidson noreply at github.com
Mon Dec 12 23:10:16 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e04c00f51164843a92a6ac55aa2917c6442f5f1
      https://github.com/WebKit/WebKit/commit/7e04c00f51164843a92a6ac55aa2917c6442f5f1
  Author: Brady Eidson <beidson at apple.com>
  Date:   2022-12-12 (Mon, 12 Dec 2022)

  Changed paths:
    M Source/WebCore/workers/service/ServiceWorkerRegistration.cpp
    M Source/WebCore/workers/service/server/SWServer.cpp
    M Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp
    M Source/WebKit/Platform/IPC/DaemonCoders.cpp
    M Source/WebKit/Platform/IPC/DaemonCoders.h
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
    A Source/WebKit/UIProcess/API/Cocoa/_WKNotificationData.h
    A Source/WebKit/UIProcess/API/Cocoa/_WKNotificationData.mm
    A Source/WebKit/UIProcess/API/Cocoa/_WKNotificationDataInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp
    M Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp
    M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.h
    M Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm

  Log Message:
  -----------
  Add some notifications related WKWebsiteDataStoreDelegate calls
https://bugs.webkit.org/show_bug.cgi?id=249164
rdar://103271182

Reviewed by Ben Nham.

Adds variants of the permissions and showNotification calls to _WKWebSiteDataStoreDelegate

Also fixes a few other issues in the push/notifications code paths.
And adds some logging.

* Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::showNotification):
* Source/WebCore/workers/service/server/SWServer.cpp:
(WebCore::SWServer::processPushMessage):
* Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp:
(WebKit::NetworkNotificationManager::getPendingPushMessages):
* Source/WebKit/Platform/IPC/DaemonCoders.cpp:
(WebKit::Daemon::Coder<WTF::UUID>::encode): Deleted.
(WebKit::Daemon::Coder<WTF::UUID>::decode): Deleted.
* Source/WebKit/Platform/IPC/DaemonCoders.h:
(WebKit::Daemon::Coder<WTF::UUID>::encode):
(WebKit::Daemon::Coder<WTF::UUID>::decode):
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
* Source/WebKit/UIProcess/API/Cocoa/_WKNotificationData.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h.
* Source/WebKit/UIProcess/API/Cocoa/_WKNotificationData.mm: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h.
(-[_WKNotificationData initWithCoreData:dataStore:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKNotificationDataInternal.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::processPushMessage):
* Source/WebKit/UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp:
(WebKit::ServiceWorkerNotificationHandler::showNotification):
* Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp:
(WebKit::WebNotificationManagerMessageHandler::showNotification):
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.h:
* Source/WebKit/UIProcess/RemoteLayerTree/mac/RemoteScrollingCoordinatorProxyMac.mm:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::showServiceWorkerNotification):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h:
(WebKit::WebsiteDataStoreClient::showNotification):
(WebKit::WebsiteDataStoreClient::notificationPermissions):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:
(messageDictionary):
(-[FirePushEventDataStoreDelegate notificationPermissionsForWebsiteDataStore:]):
(-[FirePushEventDataStoreDelegate websiteDataStore:showNotification:]):

Canonical link: https://commits.webkit.org/257778@main




More information about the webkit-changes mailing list