[webkit-changes] [WebKit/WebKit] cdc26c: Only add webNavigation object if extension has web...

b-weinstein noreply at github.com
Mon Dec 12 13:06:02 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cdc26cdce702cf573c290419b083aad7ae7a1ba4
      https://github.com/WebKit/WebKit/commit/cdc26cdce702cf573c290419b083aad7ae7a1ba4
  Author: Brian Weinstein <bweinstein at apple.com>
  Date:   2022-12-12 (Mon, 12 Dec 2022)

  Changed paths:
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm
    M Tools/TestWebKitAPI/SourcesCocoa.txt
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPINamespace.mm

  Log Message:
  -----------
  Only add webNavigation object if extension has webNavigation permission.
https://bugs.webkit.org/show_bug.cgi?id=249041
rdar://102820594

Reviewed by Timothy Hatcher.

Also add a few tests for this behavior.

* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm:
(WebKit::WebExtensionAPINamespace::isPropertyAllowed):
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPINamespace.mm: Copied from Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPINamespaceCocoa.mm.
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/257752@main




More information about the webkit-changes mailing list