[webkit-changes] [WebKit/WebKit] 591ba3: Expand site isolation testing to cover timing of _...

Alex Christensen noreply at github.com
Mon Dec 12 11:02:34 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 591ba3643d0068fd9cfbbef10586f7048e8771cf
      https://github.com/WebKit/WebKit/commit/591ba3643d0068fd9cfbbef10586f7048e8771cf
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2022-12-12 (Mon, 12 Dec 2022)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
    M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h
    M Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm

  Log Message:
  -----------
  Expand site isolation testing to cover timing of _webView:didCommitLoadWithRequest:inFrame: callback
https://bugs.webkit.org/show_bug.cgi?id=249047

Reviewed by Chris Dumez.

Also write 2 lines of code instead of using std::exchange with Ref, which asan doesn't seem to like right now.

* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::commitProvisionalFrame):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.h:
* Tools/TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
(-[TestNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):

Canonical link: https://commits.webkit.org/257742@main




More information about the webkit-changes mailing list