[webkit-changes] [WebKit/WebKit] 437442: WAAPI composite animations not working correctly

Antoine Quint noreply at github.com
Mon Dec 12 09:28:14 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4374420d956e8963d4efd9ff87e80959f916d4be
      https://github.com/WebKit/WebKit/commit/4374420d956e8963d4efd9ff87e80959f916d4be
  Author: Antoine Quint <graouts at apple.com>
  Date:   2022-12-12 (Mon, 12 Dec 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/combining-effects/effect-composition-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/combining-effects/effect-composition.html
    M Source/WebCore/animation/KeyframeEffect.cpp

  Log Message:
  -----------
  WAAPI composite animations not working correctly
https://bugs.webkit.org/show_bug.cgi?id=248944

Reviewed by Antti Koivisto.

We would only ever compute the blended additive or accumulative keyframes if the offset was either 0 or 1,
completely ignoring any keyframe in between.

* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/combining-effects/effect-composition-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/combining-effects/effect-composition.html:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle):

Canonical link: https://commits.webkit.org/257731@main




More information about the webkit-changes mailing list