[webkit-changes] [WebKit/WebKit] 1cca7e: Unreviewed clang/libstdc++ build fix in CSSCustomP...
Žan Doberšek
noreply at github.com
Mon Dec 12 06:46:56 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1cca7e6637ff445f2fbd7cc19d02c53ad07dda2f
https://github.com/WebKit/WebKit/commit/1cca7e6637ff445f2fbd7cc19d02c53ad07dda2f
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2022-12-12 (Mon, 12 Dec 2022)
Changed paths:
M Source/WebCore/css/CSSCustomPropertyValue.h
Log Message:
-----------
Unreviewed clang/libstdc++ build fix in CSSCustomPropertyValue
https://bugs.webkit.org/show_bug.cgi?id=249136
Unreviewed build fix for the Clang and libstdc++ combination.
257701 at main added the RefPtr<StyleImage> type to the CSSCustomPropertyValue's
SyntaxValue variant which ended tripping up construction of the VariantValue
variant with either CSSVariableReferenceValue or CSSVariableData Refs. This
seems to be specific to the libstdc++ std::variant<> implementation when used
alongside Clang. Workaround is to avoid the simplest conversion constructor of
the variant and instead use std::in_place_type<T> to explictly state the
intended type that's to be constructed and contained in the variant object.
* Source/WebCore/css/CSSCustomPropertyValue.h:
Canonical link: https://commits.webkit.org/257727@main
More information about the webkit-changes
mailing list