[webkit-changes] [WebKit/WebKit] 3bdc3f: Turn -webkit-mask-box-image into a shorthand

Oriol Brufau noreply at github.com
Mon Dec 12 05:15:46 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3bdc3f2824cf4d01a15ee402d7de99b099e8b3ec
      https://github.com/WebKit/WebKit/commit/3bdc3f2824cf4d01a15ee402d7de99b099e8b3ec
  Author: Oriol Brufau <obrufau at igalia.com>
  Date:   2022-12-12 (Mon, 12 Dec 2022)

  Changed paths:
    M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
    M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
    M LayoutTests/fast/css/getComputedStyle/getComputedStyle-webkit-mask-box-image.html
    M LayoutTests/fast/css/image-set-parsing-expected.txt
    M LayoutTests/fast/css/image-set-parsing.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/svg/css/getComputedStyle-basic-expected.txt
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/StyleProperties.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  Turn -webkit-mask-box-image into a shorthand
https://bugs.webkit.org/show_bug.cgi?id=249115

Reviewed by Darin Adler.

* LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt: Shorthands are not indexed in style declarations.
* LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Shorthands are not indexed in style declarations.
* LayoutTests/fast/css/getComputedStyle/getComputedStyle-webkit-mask-box-image.html: Fix bug with omitted values.
* LayoutTests/fast/css/image-set-parsing-expected.txt: getPropertyCSSValue doesn't work for shorthands.
* LayoutTests/fast/css/image-set-parsing.html: getPropertyCSSValue doesn't work for shorthands.
* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Shorthands are not indexed in style declarations.
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Shorthands are not indexed in style declarations.
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Shorthands are not indexed in style declarations.
* LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Shorthands are not indexed in style declarations.
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Shorthands are not indexed in style declarations.
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Shorthands are not indexed in style declarations.
* LayoutTests/svg/css/getComputedStyle-basic-expected.txt: Shorthands are not indexed in style declarations.
* Source/WebCore/css/CSSProperties.json: Turn -webkit-mask-box-image into a shorthand.
* Source/WebCore/css/StyleProperties.cpp: Serialize -webkit-mask-box-image as a shorthand.
(WebCore::StyleProperties::getPropertyValue const):
(WebCore::StyleProperties::borderImagePropertyValue const):
* Source/WebCore/css/parser/CSSPropertyParser.cpp: Parse -webkit-mask-box-image as a shorthand.
(WebCore::CSSPropertyParser::consumeBorderImage):
(WebCore::CSSPropertyParser::parseShorthand):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: Refactoring.
(WebCore::CSSPropertyParserHelpers::consumeReflect):
(WebCore::CSSPropertyParserHelpers::consumeWebkitBorderImage): Deleted.
* Source/WebCore/rendering/style/RenderStyle.h: Delete dead code.
(WebCore::RenderStyle::initialOutlineStyleIsAuto):
(WebCore::RenderStyle::initialNinePieceImageForMask): Deleted.
* Source/WebCore/style/StyleBuilderConverter.h: Delete dead code.
(WebCore::Style::BuilderConverter::convertBorderMask): Deleted.

Canonical link: https://commits.webkit.org/257723@main




More information about the webkit-changes mailing list