[webkit-changes] [WebKit/WebKit] 041584: Get rid of a redundant conditional expression prev...

Ahmad Saleem noreply at github.com
Sun Dec 11 23:59:30 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 041584a3ee1d8d1621a483c65f5481503d047d8f
      https://github.com/WebKit/WebKit/commit/041584a3ee1d8d1621a483c65f5481503d047d8f
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-12-11 (Sun, 11 Dec 2022)

  Changed paths:
    M Source/WebCore/editing/VisibleUnits.cpp

  Log Message:
  -----------
  Get rid of a redundant conditional expression previousBoundary()

Get rid of a redundant conditional expression previousBoundary()
https://bugs.webkit.org/show_bug.cgi?id=249092

Reviewed by Ryosuke Niwa.

Merge - https://src.chromium.org/viewvc/blink?revision=199951&view=revision

A conditional expression
|(node.renderer() && node.renderer()->isBR() && !next)|
at L574 is always false because |!next| is always false as of if-statement
at L570, which returns from function when |!next| is true.

This patch gets rid of this redundant conditional expression for improving
code health.

* Source/WebCore/editing/VisibleUnits.cpp:
(previousBoundary): Update to remove conditional function, which was always false

Canonical link: https://commits.webkit.org/257715@main




More information about the webkit-changes mailing list