[webkit-changes] [WebKit/WebKit] 4a5c7a: Allow grid shorthands to set masonry to rows and c...

Sammy Gill noreply at github.com
Sun Dec 11 21:03:05 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a5c7a9f1a2ed38438591b2c57c5cab67f125478
      https://github.com/WebKit/WebKit/commit/4a5c7a9f1a2ed38438591b2c57c5cab67f125478
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2022-12-11 (Sun, 11 Dec 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/parsing/masonry-parsing-expected.txt
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

  Log Message:
  -----------
  Allow grid shorthands to set masonry to rows and columns.
https://bugs.webkit.org/show_bug.cgi?id=249108
rdar://103231154

Reviewed by Matt Woodrow.

CSS grid has the "grid" and "grid-template" properties that can be used
to set the longhands of "grid-template-rows" and
"grid-template-columns." These shorthands should be able to set both
longhand properties to masonry if specified.

This can be done by modifiny consumeGridTrackList to check if the passed
in values are "masonry." Since createGridTrackList already checks for
the scenario where masonry is specified, the rest of the logic should
be able to remain the same.

* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/parsing/masonry-parsing-expected.txt:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeGridTrackList):

Canonical link: https://commits.webkit.org/257713@main




More information about the webkit-changes mailing list