[webkit-changes] [WebKit/WebKit] 52052a: CSS `::marker` does not support defining CSS varia...

Karl Dubost noreply at github.com
Sun Dec 11 20:14:27 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 52052a276f0d26946f17681a53b2e2339d6b24ca
      https://github.com/WebKit/WebKit/commit/52052a276f0d26946f17681a53b2e2339d6b24ca
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2022-12-11 (Sun, 11 Dec 2022)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable-computed-style-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable-computed-style.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable.html
    M Source/WebCore/style/PropertyAllowlist.cpp

  Log Message:
  -----------
  CSS `::marker` does not support defining CSS variables
https://bugs.webkit.org/show_bug.cgi?id=241566
rdar://problem/95551387

Reviewed by Tim Nguyen and Antti Koivisto.

This aligns WebKit with Firefox and Chrome. It adds
CSSPropertyCustom into isValidMarkerStyleProperty
and isValidCueStyleProperty. This also adds two new
Web Platform Tests for css marker.

* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable-computed-style-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable-computed-style.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-variable.html: Added.
* Source/WebCore/style/PropertyAllowlist.cpp:
(WebCore::Style::isValidMarkerStyleProperty):
(WebCore::Style::isValidCueStyleProperty):

Canonical link: https://commits.webkit.org/257711@main




More information about the webkit-changes mailing list