[webkit-changes] [WebKit/WebKit] 5f7b83: Layout broken on artdeconapier.com

Alan Baradlay noreply at github.com
Sun Dec 11 08:21:11 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f7b839e27213948bfd8fbeb37f059e9124f2389
      https://github.com/WebKit/WebKit/commit/5f7b839e27213948bfd8fbeb37f059e9124f2389
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2022-12-11 (Sun, 11 Dec 2022)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h

  Log Message:
  -----------
  Layout broken on artdeconapier.com
https://bugs.webkit.org/show_bug.cgi?id=248715
<rdar://problem/102939886>

Reviewed by Antti Koivisto.

This patch adds support for aligning line box relative inline boxes with stretching content.
e.g.
<div>
  <span style="vertical-align: top"><img style="width: 10px; height: 100px"></span>
</div>

(See https://w3c.github.io/csswg-drafts/css2/#propdef-vertical-align for more info)

* LayoutTests/fast/scrolling/rtl-scrollbars-elementFromPoint-static.html:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:
(WebCore::Layout::LineBoxVerticalAligner::layoutBoundsForInlineBoxSubtree const):
(WebCore::Layout::LineBoxVerticalAligner::alignInlineLevelBoxes const):
collect line box relative inline boxes and align then at the end when all the non-relative
content is done.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h:

Canonical link: https://commits.webkit.org/257700@main




More information about the webkit-changes mailing list