[webkit-changes] [WebKit/WebKit] 4ced12: [JSC] Should not assume content in scratch register

Yusuke Suzuki noreply at github.com
Fri Dec 9 19:10:13 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ced12722d5dbafd2245d6c624d539312dbc8969
      https://github.com/WebKit/WebKit/commit/4ced12722d5dbafd2245d6c624d539312dbc8969
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-12-09 (Fri, 09 Dec 2022)

  Changed paths:
    M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h
    M Source/JavaScriptCore/b3/air/AirOpcode.opcodes
    M Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp

  Log Message:
  -----------
  [JSC] Should not assume content in scratch register
https://bugs.webkit.org/show_bug.cgi?id=249059
rdar://problem/103201987

Reviewed by Justin Michaud.

We should not assume content in scratch register in MacroAssembler.
This patch fixes it so that X86 MacroAssembler functions correctly
set up content inside it.
We also fix naming of some X86 MacroAssembler functions since they
are not aligned to MacroAssembler's DEFINE_SIGNED_SIMD_FUNCS rules.

* Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::vectorTruncSatSignedFloat64):
(JSC::MacroAssemblerX86_64::vectorTruncSatUnsignedFloat64):
(JSC::MacroAssemblerX86_64::vectorConvertLowUnsignedInt32):
(JSC::MacroAssemblerX86_64::vectorConvertLowSignedInt32):
(JSC::MacroAssemblerX86_64::vectorSignedTruncSatF64): Deleted.
(JSC::MacroAssemblerX86_64::vectorUnsignedTruncSatF64): Deleted.
(JSC::MacroAssemblerX86_64::vectorConvertLow): Deleted.
* Source/JavaScriptCore/b3/air/AirOpcode.opcodes:
* Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::addSIMDV_V):

Canonical link: https://commits.webkit.org/257663@main




More information about the webkit-changes mailing list